chore(plugin): simplify plugin by mimarz · Pull Request #5466 · digdir/designsystemet

mimarz · 2026-10-02T11:00:40Z

resolves #5470

Summary

Removed preview for themes focusing on just having a simple as possible (wip) export to figma plugin.

Default feature is now an import of Designsystemet to Figma.
Improved feedback during imports.
- We give progress indicator during import and what parts of Figma is being updated
- Import log at the end for those interested with which modes, collections, variables, text styles and shadows were created.
Improved error handling, such as aborting import if font-family in config does not exits in users Figma file (which includes system fonts) or if failed on updating other parts.
Cleaned up code and renamed several parts of the plugin code to better reflect what they are doing.

Work in progress

Added experiment for exporting config from Figma. Disabled/hidden under START_VIEW const.
Added experiment for importing multiple css files as config. Disabled under feat flag, FEAT_CSS_IMPORT

changeset-bot · 2026-10-02T11:00:48Z

🦋 Changeset detected

Latest commit: b30d2f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot

Copilot review overview

🟡 Changes recommended

Notification accessibility, inaccurate warning counts, and overflowing status layouts need correction.

Review effort: Balanced
Findings: 5

Open (5)

Padded view exceeds its grid row height · New
Log view overflows instead of scrolling · New
Warning count inaccurately reports affected items · New
Warning count under-reports skipped items · New
Alert errors are not announced to assistive technology · New

What changed in this PR

Simplifies the Figma plugin into a direct configuration-to-export workflow with progress and result views.

Changes:

Removes theme previews and related dependencies.
Adds export progress, completion, and notification views.
Renames import terminology and adds plugin packaging support.

File	Description
`.gitignore`	Ignores plugin ZIP artifacts.
`pnpm-lock.yaml`	Removes unused dependencies.
`plugins/designsystemet/package.json`	Adds ZIP packaging and cleans dependencies.
`plugins/designsystemet/src/types.ts`	Defines the new message protocol.
`plugins/designsystemet/src/ui/app.tsx`	Implements the new export workflow.
`plugins/designsystemet/src/ui/app.css`	Styles status and notification views.
`plugins/designsystemet/src/ui/border-radius.ts`	Removes preview-only logic.
`plugins/designsystemet/src/ui/export-view.tsx`	Displays export progress.
`plugins/designsystemet/src/ui/finished-view.tsx`	Displays successful completion.
`plugins/designsystemet/src/ui/notifications-view.tsx`	Displays warnings, errors, and logs.
`plugins/designsystemet/src/ui/paste-view.tsx`	Updates configuration instructions.
`plugins/designsystemet/src/ui/post-to-plugin.ts`	Adds UI-to-plugin messaging.
`plugins/designsystemet/src/ui/preview-view.tsx`	Removes the theme preview.
`plugins/designsystemet/src/plugin/code.ts`	Runs validation and export in one operation.
`plugins/designsystemet/src/plugin/token-export/collection-specs.ts`	Adopts export terminology.
`plugins/designsystemet/src/plugin/token-export/effect-styles.ts`	Adopts the renamed export log.
`plugins/designsystemet/src/plugin/token-export/export-to-figma.ts`	Adds progress reporting and export naming.
`plugins/designsystemet/src/plugin/token-export/fonts.ts`	Updates export terminology.
`plugins/designsystemet/src/plugin/token-export/log.ts`	Renames the import log to export log.
`plugins/designsystemet/src/plugin/token-export/text-styles.ts`	Adopts the renamed export log.
`plugins/designsystemet/src/plugin/token-export/token-model.ts`	Updates preview-related messaging.
`plugins/designsystemet/src/plugin/token-export/variable-sync.ts`	Adopts export terminology.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🔵 Needs a closer look

It substantially changes the message protocol, UI state machine, and destructive Figma export workflow without dedicated plugin tests.

Review effort: Balanced
Findings: None

Resolved since last review (5)

Alert errors are not announced to assistive technology
Warning count under-reports skipped items
Warning count inaccurately reports affected items
Log view overflows instead of scrolling
Padded view exceeds its grid row height

Files not reviewed (1)

pnpm-lock.yaml: Generated file

github-actions · 2026-10-06T13:17:22Z

Preview deployments for this pull request:

storybook - 9. Oct 2026 - 11:55

Copilot

Copilot review overview

🟡 Changes recommended

The manifest changes the deployed plugin identity, and plugin-only pull requests will not trigger the newly configured tests.

Review effort: Balanced
Findings: 2

Open (2)

Changing the plugin ID unintentionally migrates the existing Figma plugin · New
Plugin-only PRs bypass CI because workflow paths exclude plugin changes · New

Files not reviewed (1)

pnpm-lock.yaml: Generated file

Copilot

🟡 Changes recommended

Config export mishandles prototype-named themes and semantic step names, causing data loss or silent omissions.

1 open finding

Preserve proto theme modes with a prototype-free record · New

2 resolved since last review

Plugin-only PRs bypass CI because workflow paths exclude plugin changes
Changing the plugin ID unintentionally migrates the existing Figma plugin

Files not reviewed (1)

pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

Same-collection aliases can export values from the wrong Figma mode.

1 open finding

Preserve mode when resolving same-collection aliases · New

1 resolved since last review

Preserve proto theme modes with a prototype-free record

Files not reviewed (1)

pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced

Copilot

🟡 Changes recommended

File validation breaks CSS and some JSON uploads, while __proto__ CSS themes are silently lost during import.

2 open findings

Fix MIME validation for JSON and feature-gated CSS uploads · New
Prevent proto theme loss during import · New

1 resolved since last review

Preserve mode when resolving same-collection aliases

Files not reviewed (1)

pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced

Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Copilot

🔵 Needs a closer look

Experimental config export can silently omit a completely deleted color scale without warning, producing a lossy config.

0 open findings

Files not reviewed (1)

pnpm-lock.yaml: Generated file

🧠 Review effort: Balanced

mimarz requested a balanced review from Copilot October 2, 2026 11:31

Copilot started reviewing on behalf of mimarz October 2, 2026 11:31

View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

mimarz requested a balanced review from Copilot October 2, 2026 12:30

Copilot started reviewing on behalf of mimarz October 2, 2026 12:31

View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

mimarz marked this pull request as ready for review October 2, 2026 12:58

mimarz requested review from Barsnes and eirikbacker as code owners October 2, 2026 12:58

mimarz marked this pull request as draft October 5, 2026 10:31

mimarz force-pushed the chore-rework-plugin-ui branch 2 times, most recently from 2960963 to 36a3fbe Compare October 6, 2026 12:08

mimarz marked this pull request as ready for review October 6, 2026 13:41

mimarz requested a balanced review from Copilot October 6, 2026 13:41

Copilot started reviewing on behalf of mimarz October 6, 2026 13:41

View session

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Comment thread plugins/designsystemet/manifest.json

Comment thread test/vitest.config.mjs Outdated

github-advanced-security Bot found potential problems Oct 7, 2026

View reviewed changes

Comment thread packages/cli/src/tokens/config-colors.ts Fixed

mimarz added this pull request to stack #5476 October 7, 2026 18:29

mimarz requested a balanced review from Copilot October 7, 2026 18:29

Copilot started reviewing on behalf of mimarz October 7, 2026 18:30

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread plugins/designsystemet/src/plugin/export/export-config.ts Outdated

mimarz requested a balanced review from Copilot October 7, 2026 18:57

Copilot started reviewing on behalf of mimarz October 7, 2026 18:58

View session

Copilot AI reviewed Oct 7, 2026

View reviewed changes

Comment thread plugins/designsystemet/src/plugin/export/export-config.ts Outdated

mimarz force-pushed the chore-rework-plugin-ui branch from 065af22 to 7bf6a1b Compare October 8, 2026 07:40

mimarz requested a balanced review from Copilot October 8, 2026 09:11

Copilot started reviewing on behalf of mimarz October 8, 2026 09:12

View session

Copilot AI reviewed Oct 8, 2026

View reviewed changes

Comment thread plugins/designsystemet/src/ui/views/import.tsx Outdated

Comment thread plugins/designsystemet/src/plugin/import/config-from-css.ts

mimarz added 18 commits October 9, 2026 08:35

add js prototype guard

e335526

tweaks

4d01572

fix and add test

f19391e

add test run

6a1c046

fix review comments

23961ee

fix review comments

a702916

review fixes

f1d279a

fix review comments

97f6996

chore(plugin): handle user-made variables

8fb8931

use true/false for readability

1d7ae52

use plugin version as marker for managed

22028a1

fix review comments

e2cb6c4

mark variable managed as soon as its touched

6be8997

specifics

3a4d660

skip theme if it has no colors

ad3d1a8

review fixes

1ffa085

keep duplicated or renaed styles

a10db8f

specifics

705fd64

mimarz force-pushed the chore-rework-plugin-ui branch from 3d9e542 to 705fd64 Compare October 9, 2026 06:35

mimarz requested a balanced review from Copilot October 9, 2026 06:39

Copilot started reviewing on behalf of mimarz October 9, 2026 06:39

View session

Copilot AI reviewed Oct 9, 2026

View reviewed changes

mimarz added 4 commits October 9, 2026 11:21

hide heading if home is not start view

e3cd44e

add timings and check wether to write text styles or load fonts

65c5bf0

skip self variable references as they are dropped in Figma

917df3d

add check for if a variable needs to be written

b30d2f2

Barsnes approved these changes Oct 9, 2026

View reviewed changes

clean up duplicate check

b1ea552

mimarz merged commit 9ac526c into main Oct 9, 2026
21 checks passed

mimarz deleted the chore-rework-plugin-ui branch October 9, 2026 10:35

Conversation

mimarz commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Work in progress

Uh oh!

changeset-bot Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mimarz commented Oct 2, 2026 •

edited

Loading

changeset-bot Bot commented Oct 2, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading