Repository navigation
Accept a change repeated across stories once, instead of story by story - #59
Merged
Merged
Conversation
A header that grew 15 rows changed all 124 stories of a batch, and each still had to be looked at for whatever else was in it. The batch's page now offers each hunk at least 3 undecided stories share, by the size and pixels of both sides. Accepting one draws it onto those stories' goldens, in the browser, so what's left to look at is smaller, and approves any image with nothing left. On that batch, the 28 offers approve 83 images and shrink 35 more. There's no new route or table. Which deltas are accepted is held in localStorage by batch, and what reaches a store is an ordinary approval. Each redrawn image is compared with nothing: everything outside a hunk matches, so what differs afterward is exactly the other hunks, which cli/test/deltas.test.ts shows on the real differ for every combination of them. The page's policy now allows blob: images, for what's redrawn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A delta's pixels are the same in every story, so a crop can't tell one story from another. What can be wrong is where it landed. One delta is open at a time, with previous and next through its stories, each story's crop, and all of its image on each side with every place it has the delta outlined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When one change lands on many stories, like a header change that touches every page, you currently have to review each story separately. This finds the changes that repeat and lets you accept each one once. It's fully client-side, with no SQL or stored-format changes.
What it does
localStorage, and each can be undone.POST /batches/:id/decisions, after the usual bulk confirmation. Undoing a delta doesn't take back an approval.The specs are updated:
ui.mdand its rationale,access.md, andglossary.md. The page's CSP now allowsblob:images for the redrawn goldens.Trying it on main
On
main's real batch of 124 changed stories, Selfie offers 28 deltas. Accepting them all approves 83 stories, leaves 35 with a smaller diff, and leaves 6 with no delta to accept.Testing
pnpm testpasses: ui 96, store 621 (92 skipped), render 148, cli 512.cli/test/deltas.test.tsruns the real differ over every combination of hunks, and shows that redrawing some leaves exactly the rest.Known limitations
🤖 Generated with Claude Code