fix: allow creating headers at any level without requiring parent headers#118
Open
muhamedfazalps wants to merge 2 commits into
Open
fix: allow creating headers at any level without requiring parent headers#118muhamedfazalps wants to merge 2 commits into
muhamedfazalps wants to merge 2 commits into
Conversation
…ders When creating a header at level 2 or higher without first creating a level 1 header, __add_new_item_table_of_content raised IndexError because it tried to access _table_titles[-1] on an empty list. Fix by creating intermediate level containers when they don't exist, so the table of contents tree builds correctly regardless of the order in which headers are added. Fixes didix21#69.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69
MdUtils.new_header()raisedIndexError: list index out of rangewhen called withlevel >= 2without first creating a level 1 header. This happened because__add_new_item_table_of_contenttried to access_table_titles[-1]on an empty list when navigating to the parent level.Fix: Before descending into the last child at each level, check if the current list is empty and create an intermediate container if needed. This allows headers to be created in any order, not just sequentially from level 1.
All 118 existing tests continue to pass.