fix: sort root nodes unless opted out via suppressAlphabeticalSorting#1753
Open
HendrikThePendric wants to merge 3 commits into
Open
fix: sort root nodes unless opted out via suppressAlphabeticalSorting#1753HendrikThePendric wants to merge 3 commits into
HendrikThePendric wants to merge 3 commits into
Conversation
|
Contributor
|
🚀 Deployed on https://pr-1753--dhis2-ui.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements LIBS-864
Description
Root nodes are now sorted alphabetically unless opted out via
suppressAlphabeticalSorting. I've scoped this as a fix, because I'd say that this behaviour should have been implemented all along. Sorting children but not roots, while having a genericsuppressAlphabeticalSortingprop in place is inconsistent behaviour.Incidental
yarn setup. Not sure why it didn't get added before, but it seems like a valid addition to me.Checklist