docs: remove expose_trace references - #775
Open
matthewmcneely wants to merge 1 commit into
Open
matthewmcneely wants to merge 1 commit into
matthewmcneely wants to merge 1 commit into
Conversation
The `expose_trace` flag is being removed from Dgraph in dgraph-io/dgraph#9593. Drop it from the lambda-server Docker example and correct the metrics section of the debug-information page, which described the flag as gating `/debug/vars`. It never did. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dgraph-io/dgraph#9593 removes the
expose_traceflag from Dgraph. This PR clears the references to it here, and fixes a long-standing inaccuracy on the debug-information page.docs-learn/howto/retrieving-debug-information.mdThe Metrics section said you need
--expose_trace=trueto collect/debug/varsfrom outside the instance, and that it's localhost-only otherwise. That was never true./debug/varsis served throughx.SanitizedDefaultServeMux(), which routes it straight tofilteredExpvarHandlerwith no source-IP check, so anyone who can reach the Alpha or Zero HTTP port can already read it.expose_traceonly ever settrace.AuthRequestfor thegolang.org/x/net/traceendpoints (/debug/requestsand/debug/events).Replaced with what actually happens, plus a note to restrict the port at the network layer if you don't want the metrics public.
installation/lambda-server.md--expose_tracein the Docker example is copy-paste cruft. It has nothing to do with the lambda server, and pasting it into a production compose file exposes the trace endpoints to any remote caller with sensitive data included. The command behaves identically without it.Removed from the current page and from the five versioned copies. The flag is valid in those released versions, so this isn't a correctness fix for them, but it's a bad example to ship in any of them. Happy to narrow this to
docs/only if you'd rather leave the version snapshots frozen.Related
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.