Skip to content

Prevent variable nullification on later imports #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrus merged 1 commit into from
Aug 17, 2026
+1 −3
Merged

Prevent variable nullification on later imports #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions jjava-distro/src/test/java/org/dflib/jjava/distro/KernelExecutionIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.dflib.jjava.distro;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand All @@ -12,7 +11,6 @@ public class KernelExecutionIT extends ContainerizedKernelCase {
* scenario passes even with the bug present.
*/
@Test
@Disabled
public void variableSurvivesLaterImports() throws Exception {
KernelRun run = executeInKernel(
"%maven com.fasterxml.jackson.core:jackson-databind:2.21.2",
Expand Down
2 changes: 1 addition & 1 deletion jjava-kernel/src/main/java/org/dflib/jjava/kernel/execution/CodeEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public Object eval(JShell shell, String code) {

protected Object evalSingle(JShell shell, String code) {

List<SnippetEvent> events = shell.eval(code);
List<SnippetEvent> events = shell.eval(code.strip());

Object result = null;

Expand Down
Loading