Repository navigation
chore(crypto): Release 0.4.0 of ic-pub-key - #11934
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The stacked cryptographic derivation changes and breaking public-type update warrant final human validation despite no identified blocking defects.
No open issues 🎉
What changed in this PR
Prepares ic-pub-key 0.4.0 for publication, including the stacked secp256r1 support from #11894. The minor-version bump accounts for breaking changes to re-exported management-canister types.
Changes:
- Updates release versions and finalizes the 0.4.0 changelog.
- Adds default-enabled secp256r1 derivation and shares serialization and chain-code handling.
- Documents feature selection and expands ECDSA tests with known-answer vectors, chain codes, and unknown-key rejection.
| File | Description |
|---|---|
packages/ic-pub-key/tests/tests.rs |
Adds secp256r1 vectors and strengthens ECDSA assertions. |
packages/ic-pub-key/src/lib.rs |
Implements secp256r1 support and shared key encoding helpers. |
packages/ic-pub-key/README.md |
Documents default features and selective builds. |
packages/ic-pub-key/CHANGELOG.md |
Finalizes release notes for 0.4.0. |
packages/ic-pub-key/Cargo.toml |
Bumps the version and adds the secp256r1 feature and dependency. |
packages/ic-pub-key/BUILD.bazel |
Aligns release metadata and feature settings across Bazel targets. |
Cargo.lock |
Records version 0.4.0 and the secp256r1 dependency. |
Review effort: Balanced
eichhorl
changed the title
eichhorl
changed the base branch from
master
to
eichhorl/ic-pub-key-secp256r1
October 23, 2026 14:45
eichhorl
marked this pull request as ready for review
October 23, 2026 14:46
mraszyk
approved these changes
Oct 23, 2026
Bump the version in Cargo.toml, BUILD.bazel and Cargo.lock, and turn the changelog's Unreleased section into 0.4.0, like #8599 did for 0.3.0. 0.4.0 because the re-exported ic-management-canister-types types changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
eichhorl
force-pushed
the
eichhorl/release-ic-pub-key-0.4.0
branch
from
October 23, 2026 16:47
aa42ca6 to
8a0124c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare release 0.4.0 of
ic-pub-key, like #8599 did for 0.3.0. The version changes inCargo.toml,BUILD.bazelandCargo.lock, and the changelog's[Unreleased]section becomes[0.4.0] - 2026-10-23.This PR is stacked on #11894, which adds the secp256r1 support this release ships. Until #11894 merges, this branch includes it, so the diff also shows its changes. This PR's own change is the last commit.
It's 0.4.0 rather than 0.3.1 because the types
ic-pub-keyre-exports fromic-management-canister-typeschange (0.5.0 → 0.11.0), which is a breaking change.cargo publish --package ic-pub-key --dry-runpasses. It builds the packaged crate against the publishedic-secp256k10.3.0,ic-secp256r10.3.0 andic-ed255190.6.0. After this merges, thepublish-crates.ymlworkflow can publish it withcrate-name: ic-pub-keyandcrate-version: 0.4.0.🤖 Generated with Claude Code