Skip to content

Add remember-me checkbox to the reference login form #79

Closed
#80
Closed
Add remember-me checkbox to the reference login form#79
#80
Assignees
devondragon
Labels
enhancementNew feature or request

Description

@devondragon
devondragon
opened on Aug 12, 2026

Summary

The login form at src/main/resources/templates/user/login.html posts only username and password (lines 58-73). Once remember-me support is completed in the framework (devondragon/SpringUserFramework#351), the reference login form should exercise it: without a remember-me request parameter, Spring Security's AbstractRememberMeServices never issues a cookie, so the feature is unreachable from the documented login path.

Work

Add a checkbox to the login form:

<div class="form-check">
    <input type="checkbox" id="remember-me" name="remember-me" class="form-check-input">
    <label for="remember-me" class="form-check-label">Remember me</label>
</div>

The parameter name must match the framework's rememberMeParameter (default remember-me).

Depends on

devondragon/SpringUserFramework#351 — this form change is a no-op until the framework side ships. The checkbox is harmless to add early (the parameter is ignored when remember-me is disabled), but Playwright coverage of the cookie flow needs the framework change first.

Activity

  1. devondragon
    added
    enhancementNew feature or request
    on Aug 12, 2026
  2. devondragon
    self-assigned this
    on Aug 12, 2026

  3. create-issue-branch commented on Aug 12, 2026

    @create-issue-branch
    create-issue-branchBot
    on Aug 12, 2026 – with Create Issue Branch

    Branch issue-79-Add-remember-me-checkbox-to-the-reference-login-form created!

  4. devondragon commented on Aug 12, 2026

    @devondragon
    devondragon
    on Aug 12, 2026
    OwnerAuthor

    PR ready for review: #80

    Scope (as confirmed): remember-me checkbox on the login form, ds-spring-user-framework bumped to 5.2.0, remember-me enabled in demo config (env-var-backed key, fail-fast + Secure cookie in prd), and Playwright coverage of the cookie flow. Closes on merge via the PR.

  5. devondragon
    added 3 commits that reference this issue on Aug 12, 2026

    docs: document REMEMBER_ME_KEY in the production env vars list

    0620a16

    fix(config): use a random per-start fallback for the remember-me key

    65247f7

    Add remember-me support to the reference login form (#79) (#80)

    e4a12e2
  6. devondragon
    closed this as completedin #80on Aug 13, 2026

  7. devondragon commented on Aug 13, 2026

    @devondragon
    devondragon
    on Aug 13, 2026
    OwnerAuthor

    Work Complete — PR Merged

    PR: Add remember-me support to the reference login form (#79)
    Merged into: main (squash)
    Branch: feature/79-remember-me-checkbox-login-form

    Summary of changes

    • Remember-me checkbox on the login form, posting the framework-default remember-me parameter
    • ds-spring-user-framework bumped to 5.2.0 (completed remember-me support, framework #351)
    • Remember-me enabled in demo config: key from REMEMBER_ME_KEY with a random per-start fallback; prd profile fail-fast (no fallback) + useSecureCookie: true
    • Playwright coverage: persistent cookie issued when checked, none when unchecked, auto-login after session-cookie loss, fresh-login baseline
    • REMEMBER_ME_KEY documented in the README production env vars

    Files changed

    build.gradle
src/main/resources/templates/user/login.html
src/main/resources/application.yml
src/main/resources/application-prd.yml
src/main/resources/messages/messages.properties
playwright/src/pages/LoginPage.ts
playwright/tests/auth/remember-me.spec.ts
README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions