Skip to content

Config maxSize() implementation #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnatan merged 3 commits into from
Aug 14, 2026
Merged

Config maxSize() implementation #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a79ad0
fix: missing `maxSize()` implementation
devnatan Aug 14, 2026
3469470
chore: remove comments
devnatan Aug 14, 2026
7627e41
refactor: lint codebase
devnatan Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions ...ples/paper/src/main/java/me/devnatan/inventoryframework/runtime/view/RowColumnSample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@
import me.devnatan.inventoryframework.ViewConfigBuilder;
import me.devnatan.inventoryframework.context.RenderContext;
import me.devnatan.inventoryframework.state.MutableIntState;
import me.devnatan.inventoryframework.state.MutableState;
import org.bukkit.Material;
import org.bukkit.inventory.ItemStack;
import org.jetbrains.annotations.NotNull;

public class RowColumnSample extends View {

private final MutableIntState intState = mutableState(0);
private final MutableIntState intState = mutableState(0);

@Override
public void onInit(@NotNull ViewConfigBuilder config) {
Expand All @@ -20,16 +19,15 @@ public void onInit(@NotNull ViewConfigBuilder config) {

@Override
public void onFirstRender(@NotNull RenderContext render) {
render.slot(13)
.withItem(intState.get(render) == 3 ? new ItemStack(Material.GOLD_INGOT) : new ItemStack(Material.IRON_INGOT));
render.slot(13)
.withItem(
intState.get(render) == 3
? new ItemStack(Material.GOLD_INGOT)
: new ItemStack(Material.IRON_INGOT));

render.firstRow((pos, slot) ->
slot.withItem(new ItemStack(Material.BLUE_STAINED_GLASS_PANE))
.onClick(click -> intState.increment(click))
);
render.firstRow((pos, slot) -> slot.withItem(new ItemStack(Material.BLUE_STAINED_GLASS_PANE))
.onClick(click -> intState.increment(click)));

render.lastColumn((pos, slot) ->
slot.withItem(new ItemStack(Material.BLACK_STAINED_GLASS_PANE))
);
render.lastColumn((pos, slot) -> slot.withItem(new ItemStack(Material.BLACK_STAINED_GLASS_PANE)));
}
}
3 changes: 0 additions & 3 deletions inventory-framework-api/src/main/java/me/devnatan/inventoryframework/ViewConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ public <T> boolean isOptionSet(@NotNull Option<T> option) {
return false;
}

// TODO docs
@SuppressWarnings("unused")
@VisibleForTesting
public <T> boolean isOptionSet(@NotNull Option<T> option, T value) {
Expand All @@ -145,7 +144,6 @@ public static <T> Option<T> createOption(@NotNull String name, @NotNull T defaul
public ViewConfig merge(ViewConfig other) {
if (other == null) return this;

// TODO merge "options" and "modifiers" from both, distinctly
return new ViewConfig(
merge(other, ViewConfig::getTitle, Objects::nonNull),
merge(other, ViewConfig::getSize, value -> value != 0),
Expand All @@ -169,7 +167,6 @@ private <T> T merge(ViewConfig other, Function<ViewConfig, T> retriever, Functio
return value;
}

// TODO docs
@SuppressWarnings("unused")
@FunctionalInterface
public interface Modifier {
Expand Down
13 changes: 10 additions & 3 deletions inventory-framework-api/src/main/java/me/devnatan/inventoryframework/ViewConfigBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,14 @@ public ViewConfigBuilder size(int size) {
return this;
}

// TODO needs documentation
/**
* Expands the size of the inventory to the max permitted by {@link #getType() its type}.
*
* @return This configuration builder.
* @see ViewType#getMaxSize()
*/
public ViewConfigBuilder maxSize() {
throw new UnsupportedOperationException("TODO");
return size(Integer.MAX_VALUE);
}

/**
Expand Down Expand Up @@ -278,9 +283,11 @@ public ViewConfig build() {
option, option.defaultValue()))
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));

final int size = getSize() == Integer.MAX_VALUE ? getType().getMaxSize() : getSize();

return new ViewConfig(
getTitle(),
getSize(),
size,
getType(),
optionsMap,
getLayout(),
Expand Down
Loading