fix: refuse a second Wayscriber prefix so overlay spawn stays on one binary - #345
Merged
Conversation
Refuse unmanaged copies under the other prefix, ~/.local/bin, and a dest-mismatched user unit unless --replace-other is passed. Warn at daemon start when another binary is still on PATH, and do not close "I don't have that setting" reports until the change is in a tagged release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overlay spawn follows the running daemon's file, not whichever
wayscriberthe user ran--version/--abouton. A leftover copy under/usr,/usr/local, or~/.local/binmakes those commands disagree with the overlay and looks like a missing setting../tools/install.shunless--replace-otheris passed or the operator confirms on a TTY. A symlink that already resolves to the dest is not a conflict.wayscriberfile is still onPATHor under those well-known prefixes.--versionis the crate version, not a git hash).