Repository navigation
feat: shell completion and Linux/macOS/Windows CI matrix - #3
Open
RogerCecilpot wants to merge 1 commit into
Open
RogerCecilpot wants to merge 1 commit into
RogerCecilpot wants to merge 1 commit into
Conversation
This was referenced Oct 25, 2026
RogerCecilpot
force-pushed
the
feat/257-completion-windows-ci
branch
from
October 25, 2026 12:56
a528af3 to
86e0e9d
Compare
RogerCecilpot
changed the base branch from
feat/235-scaffold
to
feat/246-output-errors-exit-codes
October 25, 2026 12:57
Add an explicit `completion bash|zsh|fish|powershell` command with install instructions per shell, replacing Cobra's default. Pin the shape of the `version` line with a test. The test job now runs on ubuntu, macOS and Windows, building the binary and generating every completion script on each. Refs devlyft/devlyft#257 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RogerCecilpot
force-pushed
the
feat/246-output-errors-exit-codes
branch
from
October 25, 2026 13:00
ab68d4d to
dd9fe8c
Compare
RogerCecilpot
force-pushed
the
feat/257-completion-windows-ci
branch
from
October 25, 2026 13:00
86e0e9d to
d5618b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes devlyft/devlyft#257.
Stacked on #2 (scaffold); retarget to
mainonce that merges.What
devlyft completion bash|zsh|fish|powershellreplaces Cobra's default command, with install instructions for each shell and strict argument validation.version: the line's shape is pinned by a test, and extra arguments are rejected.testjob is a matrix overubuntu-latest,macos-latestandwindows-latest(fail-fast: false). Each runsgo test -race, builds the binary, runsversionand generates every completion script. Windows uses Git Bash and callsgodirectly becausemakeisn't available.Notes
checks / testbecomeschecks / test (ubuntu-latest),checks / test (macos-latest)andchecks / test (windows-latest). The ruleset needs to list all three when the required checks are added.🤖 Generated with Claude Code