Skip to content
This repository was archived by the owner on Oct 16, 2026. It is now read-only.

[WIP] Update dependencies to target versions - #93

Closed
kzu with Copilot wants to merge 8 commits into
mainfrom
copilot/bump-all-open-dependency-updates
Closed

kzu with Copilot wants to merge 8 commits into
mainfrom
copilot/bump-all-open-dependency-updates

Conversation

Copilot AI commented Oct 12, 2026 •

Copy link
Copy Markdown

Copilot AI assigned Copilot and kzu Oct 12, 2026
Copilot AI linked an issue Oct 12, 2026 that may be closed by this pull request
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
@kzu

kzu commented Oct 13, 2026

Copy link
Copy Markdown
Member

@copilot please fix the build: (1) dotnet-format IDE0040 in IExtensionsManager.cs by removing the unnecessary accessibility modifiers, and (2) the NuGetizer "'' is not a valid version string" error on Terminal.Shell.Sdk.Pack (empty package version). This must be a small build-only fix. Keep changes limited to build/test/format/workflow/version only, no product code or public API changes, never downgrade anything already on main, and keep CI green.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Author

@copilot please fix the build: (1) dotnet-format IDE0040 in IExtensionsManager.cs by removing the unnecessary accessibility modifiers, and (2) the NuGetizer "'' is not a valid version string" error on...

Fixed in b69b5de: removed the unnecessary public modifier and added a conditional package-version fallback based on the existing build version. MSBuild evaluates the expected CI version. Local build/format validation is blocked by the unreachable pkg.kzu.app feed, and the latest GitHub run is action_required with no jobs.

@kzu

kzu commented Oct 13, 2026

Copy link
Copy Markdown
Member

@copilot the build still fails in CI (run 38392172281): NuGetizer 0.9.1 NuGetizer.Shared.targets(279,5): error : '' is not a valid version string on src/Terminal.Shell.Sdk.Pack/Terminal.Shell.Sdk.Pack.msbuildproj. The PackageVersion fallback to $(Version) isn't enough since Version is also empty there in CI. Please make a small build-only fix so the Sdk.Pack project gets a valid package version (and verify with the same build command the workflow runs). No product code changes.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Author

@copilot the build still fails in CI (run 38392172281): NuGetizer 0.9.1 NuGetizer.Shared.targets(279,5): error : '' is not a valid version string on src/Terminal.Shell.Sdk.Pack/Terminal.Shell.Sdk.Pack...

Fixed in b93e378: the SDK pack’s fallback now runs after the shared .msbuildproj version defaults, scoped to that project. Under PR CI inputs, MSBuild evaluates PackageVersion as 42.42.0-pr93.223. I ran the workflow’s dotnet build -m:1 command, but restore could not reach pkg.kzu.app; the GitHub run is action_required with no job results.

@kzu

kzu commented Oct 13, 2026

Copy link
Copy Markdown
Member

@copilot Please hold Microsoft.Build.NoTargets at 3.6.0 (main's version) and keep the rest of the bumps.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Author

@copilot Please hold Microsoft.Build.NoTargets at 3.6.0 (main's version) and keep the rest of the bumps.

Restored Microsoft.Build.NoTargets to 3.6.0 in d1470f9; all other dependency bumps remain unchanged.

@kzu

kzu commented Oct 13, 2026

Copy link
Copy Markdown
Member

@copilot Final attempt on this PR. Please:

  1. Restore Microsoft.Build.NoTargets to 3.7.0. Holding it at 3.6.0 (d1470f9) didn't fix anything, so it wasn't the cause.
  2. Find the real cause of the empty version string and fix it with build/version-only changes: no functional code and no package downgrades.

Failing log (build-ubuntu-latest, run 38397192825):

/home/runner/.nuget/packages/nugetizer/0.9.1/build/NuGetizer.Shared.targets(279,5): error : '' is not a valid version string. [src/Terminal.Shell.Sdk.Pack/Terminal.Shell.Sdk.Pack.msbuildproj]

Hypothesis: none of this PR's bumps cause it. NuGetizer is still 0.9.1, the same as on main, and the build workflow on main has been red since Apr 16. It looks like an old failure that the newer SDK on the runner exposes. NuGetizer 0.9.1 reads PackageVersion on the NoTargets .msbuildproj before src/Directory.Build.targets falls back to setting Version/PackageVersion, because .msbuildproj doesn't import DefaultAssemblyInfo.targets. That would explain why the late fallbacks from the earlier commits (b69b5de, b93e378) don't help. Suggested fixes, in order:

  • Bump NuGetizer to the current release (an upward version change).
  • Or set Version/PackageVersion early (Directory.Build.props, or a default in the Sdk.Pack project) and remove the ineffective fallbacks added in Directory.Build.targets.

If the fix turns out to need anything beyond build/version changes, leave it as is and say so.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 13, 2026

Copy link
Copy Markdown
Author

@copilot Final attempt on this PR. Please:

  1. Restore Microsoft.Build.NoTargets to 3.7.0. Holding it at 3.6.0 (d1470f9) didn't fix anything, so it wasn't the cause....

Fixed in 1ad9d2e: restored Microsoft.Build.NoTargets to 3.7.0, set PackageVersion in the pack project before NuGetizer targets evaluate it using the existing version inputs, and removed the ineffective late fallback. Local, PR, and release-tag MSBuild evaluations all return valid versions. The full workflow build is still blocked at restore because pkg.kzu.app is unreachable.

@kzu

kzu commented Oct 16, 2026

Copy link
Copy Markdown
Member

@copilot Please bump NuGetizer to the latest stable version (1.5.1) everywhere it's referenced, to fix the "'' is not a valid version string" failure packing src/Terminal.Shell.Sdk.Pack. Build/version changes only, no product code. Drop the earlier PackageVersion workaround if it's no longer needed.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 16, 2026

Copy link
Copy Markdown
Author

@copilot Please bump NuGetizer to the latest stable version (1.5.1) everywhere it's referenced, to fix the "'' is not a valid version string" failure packing src/Terminal.Shell.Sdk.Pack. Build/version...

Updated centralized NuGetizer to 1.5.1 and removed the earlier PackageVersion workaround in b931d62; Microsoft.Build.NoTargets remains at 3.7.0. The workflow-equivalent build was attempted but restore failed with NU1301 because pkg.kzu.app is unreachable, so CI has not yet verified the pack.

@kzu

kzu commented Oct 16, 2026

Copy link
Copy Markdown
Member

@copilot The NuGetizer error is gone, but the build now fails in Terminal.Shell.CodeAnalysis.Tests: 'AnalyzerTest<...>' does not contain a definition for 'CompilationTransforms' (Helpers/CodeAnalysis.cs lines 28 and 109), plus a MissingMethodException for MetadataReference.CreateFromAssemblyInternal in ContextExpressionGenerator. This looks like a Microsoft.CodeAnalysis.*Testing / Roslyn version mismatch from the bumps. Please hold back whichever testing/Roslyn package bump caused it (keep them at main's versions; Roslyn must never be bumped) so the build is green. Version changes only.

Co-authored-by: kzu <169707+kzu@users.noreply.github.com>

Copilot AI commented Oct 16, 2026

Copy link
Copy Markdown
Author

@copilot The NuGetizer error is gone, but the build now fails in Terminal.Shell.CodeAnalysis.Tests: 'AnalyzerTest<...>' does not contain a definition for 'CompilationTransforms' (Helpers/CodeAnalysis....

Reverted the only relevant PR-specific compatibility bump in 0ffc092: central Microsoft.VisualStudio.Composition is back to main’s 17.1.20 and the TSh override to 17.2.41. Roslyn 4.4.0 and analyzer-testing 1.1.2-dev were already at main’s versions and remain unchanged. Local build restore is blocked by unreachable pkg.kzu.app, so the CI result is still pending.

@kzu

kzu commented Oct 16, 2026

Copy link
Copy Markdown
Member

Closing without merge; repo is being archived.

@kzu kzu closed this Oct 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump all open dependency updates together

2 participants