Repository navigation
Conversation
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
|
@copilot please fix the build: (1) dotnet-format IDE0040 in IExtensionsManager.cs by removing the unnecessary accessibility modifiers, and (2) the NuGetizer "'' is not a valid version string" error on Terminal.Shell.Sdk.Pack (empty package version). This must be a small build-only fix. Keep changes limited to build/test/format/workflow/version only, no product code or public API changes, never downgrade anything already on main, and keep CI green. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Fixed in |
|
@copilot the build still fails in CI (run 38392172281): NuGetizer 0.9.1 NuGetizer.Shared.targets(279,5): error : '' is not a valid version string on src/Terminal.Shell.Sdk.Pack/Terminal.Shell.Sdk.Pack.msbuildproj. The PackageVersion fallback to $(Version) isn't enough since Version is also empty there in CI. Please make a small build-only fix so the Sdk.Pack project gets a valid package version (and verify with the same build command the workflow runs). No product code changes. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Fixed in |
|
@copilot Please hold Microsoft.Build.NoTargets at 3.6.0 (main's version) and keep the rest of the bumps. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Restored |
|
@copilot Final attempt on this PR. Please:
Failing log (build-ubuntu-latest, run 38397192825): Hypothesis: none of this PR's bumps cause it. NuGetizer is still 0.9.1, the same as on main, and the
If the fix turns out to need anything beyond build/version changes, leave it as is and say so. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Fixed in |
|
@copilot Please bump NuGetizer to the latest stable version (1.5.1) everywhere it's referenced, to fix the "'' is not a valid version string" failure packing src/Terminal.Shell.Sdk.Pack. Build/version changes only, no product code. Drop the earlier PackageVersion workaround if it's no longer needed. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Updated centralized NuGetizer to 1.5.1 and removed the earlier |
|
@copilot The NuGetizer error is gone, but the build now fails in Terminal.Shell.CodeAnalysis.Tests: 'AnalyzerTest<...>' does not contain a definition for 'CompilationTransforms' (Helpers/CodeAnalysis.cs lines 28 and 109), plus a MissingMethodException for MetadataReference.CreateFromAssemblyInternal in ContextExpressionGenerator. This looks like a Microsoft.CodeAnalysis.*Testing / Roslyn version mismatch from the bumps. Please hold back whichever testing/Roslyn package bump caused it (keep them at main's versions; Roslyn must never be bumped) so the build is green. Version changes only. |
Co-authored-by: kzu <169707+kzu@users.noreply.github.com>
Reverted the only relevant PR-specific compatibility bump in |
|
Closing without merge; repo is being archived. |
git diff --checkpassed;dotnet testwas blocked during restore becausehttps://pkg.kzu.app/index.jsonis unreachable.