Add an async-aware Proceed extension for behaviors. - #273
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviors see a
TaskorValueTaskas an ordinary return value. A reusable behavior cannot hard-code the result type, and Native AOT cannot look that result up with reflection.IMethodInvocation.Proceedcalls the rest of the pipeline and hands the behavior a settledProceedOutcome:AsyncRegistry.Register<T>()installs the closed adapters forTask<T>andValueTask<T>. The generator emits that call from the stunt static constructor. Non-genericTaskandValueTaskadapters ship with the library.Closes #263.
Tests
ValueTask<T>.Task<int>(Castle/ProceedClassTests.cs).AsyncRegistry.Register<int>()andAsyncRegistry.Register<string>().