Fix Windows source-contract self-match (4.4.0) - #4
Merged
Conversation
include_str!("lib.rs") matched the forbidden-path assertion itself, so
windows-2025 cargo test failed after 4.3.0. Scan the production half,
split the needle, and cover the same check in the Linux script contract.
Co-authored-by: Dariush vesal <dariush.vesal@gmail.com>
devlifeX
marked this pull request as ready for review
August 18, 2026 16:57
Keeps the source-contract fix that unblocked windows-2025 cargo test. Co-authored-by: Dariush vesal <dariush.vesal@gmail.com>
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
v4.3.0failed Windows CI (cargo test --workspace) on:tests::packaged_connect_stages_into_the_helper_generation_rootThe source contract used
include_str!("lib.rs")plus!containsof the olduser_data_dir.join("runtime").join("generations")snippet. That needle is also the assertion itself, so the test always failed.#![cfg(windows)]hid it from Linux.Fix
mod tests {.scripts/tauri-contract.test.mjsso Linuxpnpm checkcovers it.v4.4.0so GitHub Release publishes (4.3.0 is already tagged).Runtime Connect/staging behavior is unchanged from 4.3.0. The Windows
cargo test --workspacejob on this branch already passed.