Fix Windows Connect generation staging (4.3.0) - #3
Merged
Conversation
NSIS perMachine expands $LOCALAPPDATA to C:\ProgramData, so 4.2 helper.toml looked in C:\ProgramData\biflow\runtime\generations while the desktop wrote under the user's LocalAppData. Stage at C:\ProgramData\iran-split\staging, grant Users modify, and bump to 4.3.0. Co-authored-by: Dariush vesal <dariush.vesal@gmail.com>
Keep helper source contracts free of LOCALAPPDATA literals and match the ProgramData staging path in the Tauri installer tests. Co-authored-by: Dariush vesal <dariush.vesal@gmail.com>
devlifeX
marked this pull request as ready for review
August 18, 2026 16:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows 4.2 Connect failed at
register_runtime_generationwith:staged generation … is unreadable at C:\ProgramData\biflow\runtime\generations\… (os error 2)NSIS
perMachineusesSetShellVarContext all, so$LOCALAPPDATAexpands toC:\ProgramData. The helper recorded that path inhelper.tomlwhile the desktop staged generations under the user’s%LOCALAPPDATA%\biflow\runtime\generations. SYSTEM never saw the files.Fix (ADR 0064)
C:\ProgramData\iran-split\staging(sibling ofruntime, never nested inside it).$PROGRAMDATA\iran-split\staging; in-app Install andWindowsPaths.generation_staging_diruse the same root.--staging-dirand grants Builtin\Users modify viaicacls.4.3.0.A 4.3 NSIS install (or in-app Helper Install) rewrites
helper.tomland the ACL. Then Connect stages where the helper already looks.