compiler: Fix SizeOf reconstruction#2946
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2946 +/- ##
==========================================
+ Coverage 83.45% 83.47% +0.02%
==========================================
Files 249 249
Lines 52241 52276 +35
Branches 4500 4503 +3
==========================================
+ Hits 43598 43638 +40
+ Misses 7883 7880 -3
+ Partials 760 758 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
hotfix-sizeof
branch
from
f48b787 to
6bd6088
Compare
| return self.arguments[0] | ||
|
|
||
| @cached_property | ||
| def ctype(self): |
There was a problem hiding this comment.
This looks quite weird to have to compare those str
There was a problem hiding this comment.
SizeOf was fundamentally broken even before the tweaks in the last merged PR. The new tests exposes them. I admit it gave me a headache or two this morning to come up with something "sufficiently clean", I guess that's the best I can do for now
FabioLuporini
force-pushed
the
hotfix-sizeof
branch
from
6bd6088 to
865e787
Compare
FabioLuporini
force-pushed
the
hotfix-sizeof
branch
from
865e787 to
12df74b
Compare
| if not all(c == '*' for c in str(stars)): | ||
| raise ValueError("`stars` must be a string of zero or more `*` characters") | ||
|
|
||
| if not isinstance(intype, (str, ReservedWord)): |
There was a problem hiding this comment.
Not sure i understand how can end up here. Line 983-990 already enforce that, it cannot be not a str at this point
There was a problem hiding this comment.
reconstruction voodoo IIRC
|
(approved offline, merging) |
2 participants
Hotfix