Skip to content

fix: corebluetooth peripheral name - #447

Merged
qdot merged 2 commits into
deviceplug:devfrom
szymonlesisz:fix/corebluetooth-name
Feb 21, 2026
Merged

qdot merged 2 commits into
deviceplug:devfrom
szymonlesisz:fix/corebluetooth-name

Conversation

@szymonlesisz

@szymonlesisz szymonlesisz commented Oct 22, 2025 •

Copy link
Copy Markdown
Contributor

as well described here peripheral local_name and advertisement_name are two different things and it is justified to keep them separated as situation that local_name is not equal advertisement_name could happen in all platforms and can be implemented later as followup.

currently it is quite unfortunate that the API changes the peripheral local_name (GAP) by joining those two values

changes:

  1. added Peripheral.advertisement_name - default None
  2. implement advertisement_name in corebluetooth

fix: #434

@tternes

tternes commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Thank you for working on this! I should be able to do some testing this week and share feedback.

@tternes

tternes commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

I finally had a chance to test this in our setup. It works exactly as expected. Really nice solution.

Thanks @szymonlesisz!

@qdot qdot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this does seem like the correct thing to do, and probably should've been done from the start but we're still dealing with issues we inherited from forking 7+ years ago heh.

Main issue is going to be adapting it to the rest of the platforms so we're consistent, but I'll handle that.

@qdot
qdot merged commit 3a7d50c into deviceplug:dev Feb 21, 2026
5 checks passed
@tternes

tternes commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Ok, this does seem like the correct thing to do, and probably should've been done from the start but we're still dealing with issues we inherited from forking 7+ years ago heh.

Main issue is going to be adapting it to the rest of the platforms so we're consistent, but I'll handle that.

I'm happy to help with testing when you have a PR ready.

qdot added a commit that referenced this pull request Feb 22, 2026
Followup to #447, we'll want to make sure we emit on change to either.
qdot added a commit that referenced this pull request Feb 22, 2026
Followup to #447, we'll want to make sure we emit on change to either.
@qdot

qdot commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

@tternes It's actually sitting on dev now because I wasn't watching what I was doing heh. Feel free to give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants