Skip to content

ci: pass --comment so the Claude review is actually posted to the PR#8

Merged
riglar merged 1 commit into
devfrom
ci/claude-review-comment-flag
Jun 12, 2026
Merged

ci: pass --comment so the Claude review is actually posted to the PR#8
riglar merged 1 commit into
devfrom
ci/claude-review-comment-flag

Conversation

@riglar

@riglar riglar commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Second half of the silent-review fix. PR #6 granted pull-requests: write (the token could now post), but PR #7's review still posted nothing. Root cause this time is in the code-review plugin's own spec, step 7:

If --comment argument was NOT provided, stop here. Do not post any GitHub comments.

Our prompt invoked /code-review:code-review <repo>/pull/<n> without --comment, so the review ran (8 turns on #7), validated its findings, and discarded them — and with show_full_output: false the verdict isn't even visible in the workflow log.

With --comment: issues → inline PR comments via the plugin's inline-comment tool; no issues → a summary comment. Both paths need the write permission from #6, so the two fixes compose.

Test plan

Note: the claude-review check on this PR will fail with "Workflow validation failed" — that's the action's anti-tamper guard, which refuses to run a workflow file that differs from the default branch's copy (same as on #6; the action's own error message says to ignore it). The real test is the next PR after this merges, which should finally receive a visible review comment.

🤖 Generated with Claude Code

The code-review plugin's spec stops before posting anything when
--comment is absent: "If --comment argument was NOT provided, stop
here. Do not post any GitHub comments." Combined with
show_full_output: false, the review on PR #7 ran to completion and was
entirely discarded. The pull-requests: write permission from #6 was
necessary but not sufficient — this flag is the missing half.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@riglar riglar merged commit 6cdf93d into dev Jun 12, 2026
1 of 2 checks passed
@riglar riglar deleted the ci/claude-review-comment-flag branch June 18, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant