Deprecate Maestro 1.39.1 and 2.4.0#2
Merged
Conversation
Add both to REMOVED_MAESTRO_VERSIONS so the CLI hard-errors locally, matching the dcd API gate. JSDoc example in the generated schema types also pruned to keep the dev-server example aligned with reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.39.1and2.4.0toREMOVED_MAESTRO_VERSIONSinsrc/commands/cloud.tsso the CLI hard-errors locally before reaching the API, matching the dcdcompatibility.service.tschange.1.39.1entry from the JSDoc example insrc/types/schema.types.tsandsrc/types/generated/schema.types.tsto keep them aligned with the live dcd swagger.No
DEPRECATED_MAESTRO_VERSIONSblock exists here (only the legacy dcd CLI had one) — nothing to delete.Validation
pnpm lint— 0 errors (pre-existing warnings only)pnpm build— cleanTest plan
pnpm dcd cloud ... --maestro-version 1.39.1against any backend — expect CliError before any network callContext
Pairs with
moropo-com/dcd#<pending>,moropo-com/infra#<pending>,devicecloud-dev/docs#<pending>, andmoropo-com/back-office#<pending>. Active CLI isn't shipping yet — landing this so it's ready when the cutover happens.