fix(e2e): update rpc-go v3 CLI flags#3407
Merged
Merged
Conversation
f77d5ab to
aaa85c1
Compare
753f1c5 to
c4caa8f
Compare
There was a problem hiding this comment.
Pull request overview
Updates Cypress RPC activation e2e specs to use shared helpers and rpc-go v3 (Kong) CLI flag syntax, reducing command-construction duplication between cloud and console activation paths.
Changes:
- Centralized rpc-go command building and AMT info parsing into
activation.spec.tsfor reuse. - Updated cloud/console activation specs to use shared helpers (
getAmtInfo, version detection, and command builders). - Standardized “not activated” control-mode checks across specs via a shared allowed list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cypress/e2e/integration/rpc/activation.spec.ts | Adds shared AMT parsing helpers and rpc-go v3 command builders for cloud/console activation flows. |
| cypress/e2e/integration/rpc/cloud.activation.spec.ts | Refactors cloud activation spec to use shared AMT parsing + command builders and simplifies per-test setup. |
| cypress/e2e/integration/rpc/console.activation.spec.ts | Refactors console activation spec to use shared AMT parsing + command builders and standardizes activation-state checks. |
Comments suppressed due to low confidence (1)
cypress/e2e/integration/rpc/console.activation.spec.ts:138
- This assertion uses
[data-cy="biosReleaseDate"], but the UI and other e2e specs use[data-cy="biosReleaseData"]. WhenamtVersion < 11, this selector mismatch will cause the console activation e2e to fail even if the page is correct.
cy.get('[data-cy="biosManufacturer"]').should('not.be.empty')
cy.get('[data-cy="biosVersion"]').should('not.be.empty')
cy.get('[data-cy="biosReleaseDate"]').should('not.be.empty')
cy.get('[data-cy="biosTargetOS"]').should('not.be.empty')
c4caa8f to
4cf6c8a
Compare
- Update rpc.exe/docker invocations to rpc-go v3 Kong CLI syntax (--json, --skip-amt-cert-check, --password, -configv2 -> --profile), fixing the JSON.parse failures caused by the old single-dash flags. - Extract getAmtInfo/getAmtVersion and buildInfoCommand/ buildActivateCommand/buildDeactivateCommand into activation.spec.ts so cloud and console specs share one implementation instead of duplicating command-string building and amtinfo parsing. - Replace the per-file updateCommandsForVersion closures with a single root-level before() hook that builds the activate command once per spec file using the detected AMT version.
4cf6c8a to
483a1ca
Compare
choonkeat1986
approved these changes
Jul 3, 2026
RosieAMT
pushed a commit
that referenced
this pull request
Jul 6, 2026
## [3.58.2](v3.58.1...v3.58.2) (2026-07-06) ### Bug Fixes * **e2e:** update rpc-go v3 CLI flags ([#3407](#3407)) ([9ccec21](9ccec21))
|
🎉 This PR is included in version 3.58.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )
tested using workflow dispatch: https://github.com/device-management-toolkit/e2e-testing/pull/110