fix: preserve heat settings when turning on the fireplace - #139
Merged
Conversation
`turn_on()` reads the full fire overview specifically so it can preserve existing settings, but it only ever wrote back ModeParam (321) and FlameEffectParam (322). HeatParam (323) — heat status, heat mode, setpoint temperature and boost duration — is a separate parameter and was never captured or written, so powering on left the heater state unconstrained: a fire whose heater was off could start heating as a side effect of the MANUAL mode write, while consumers deriving power state from `HeatParam.heat_status` still reported the heater as off. Capture HeatParam in the overview read `turn_on()` already performs and write it back unchanged alongside ModeParam, exactly as is already done for FlameEffectParam. The heater keeps whatever status, mode, setpoint and boost duration the fire reported. `turn_off()` is unchanged: it writes STANDBY, which stops the heater by design. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D1yvvxN11TEbSs6sMsR3K7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
turn_on()reads the full fire overview specifically so it can preserve existing settings, but it only ever wrote back ModeParam (321) and FlameEffectParam (322). HeatParam (323) — heat status, heat mode, setpoint temperature and boost duration — is a separate parameter and was never captured or written, so powering on left the heater state unconstrained: a fire whose heater was off could start heating as a side effect of the MANUAL mode write, while consumers deriving power state fromHeatParam.heat_statusstill reported the heater as off.Capture HeatParam in the overview read
turn_on()already performs and write it back unchanged alongside ModeParam, exactly as is already done for FlameEffectParam. The heater keeps whatever status, mode, setpoint and boost duration the fire reported.turn_off()is unchanged: it writes STANDBY, which stops the heater by design.Claude-Session: https://claude.ai/code/session_01D1yvvxN11TEbSs6sMsR3K7