AMP-31189: Add _embed=true to getPages, matching getPosts - #84
Merged
Merged
Conversation
Pages never resolved featured-media data via _embedded, unlike posts which already request _embed=true. Needed so page-level OG tags can include a real featured image.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing getPosts behavior, and safely composes with both preview and non-preview query-string construction.
Pull request overview
This PR aligns the Pages REST request behavior with Posts by requesting embedded resources (_embed=true) so page responses include resolved featured-media data needed for accurate OG image tags.
Changes:
- Update
getPagesquery construction to include_embed=truealongsidelang=..., matchinggetPosts.
File summaries
| File | Description |
|---|---|
wp-react-lib/src/api/index.js |
Adds _embed=true to the pages endpoint query string so featured-media can be retrieved via _embedded. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages never resolved featured-media data via _embedded, unlike posts which already request _embed=true. Needed so page-level OG tags can include a real featured image.