feat(deps): allow worker 0.8.x for the cf-workers runtime - #124
Conversation
worker was constrained to 0.7.x, blocking downstream Cloudflare Workers consumers from using the current worker 0.8.5. The wasm-streams conflict that originally forced a pin was resolved by the object_store 0.14 / reqwest 0.13 upgrade, so 0.8 builds cleanly with no source changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude finished @alukach's task in 2m 3s —— View job Reviewing PR #124
❌ Changes requested — see findings below.
Simplify (ponytail) Nothing to flag — this is a mechanical dependency bump with no new abstractions or dependencies introduced by hand. 💰 Estimated review cost: $0.66 · 2m02s · 22 turns |
worker-build ^0.7 rejects worker 0.8.5 ("Unsupported version"), breaking
the "Build worker" CI step and the preview deploy. Bump the pin in both
the CI workflow and the example wrangler.toml, and drop the now-stale
wasm-streams note on the worker dep.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Addressed the requested change: bumped Retitled |
Root cause — worker 0.8 is blocked upstream (not just the worker-build pin)Bumping Why: two
Their wasm-bindgen exports (
No local fix available: Recommendation: hold this PR (blocked) or close it until a reqwest release moves to wasm-streams 0.6. Keeping the |
What I'm changing
Downstream Cloudflare Workers services that depend on multistore couldn't upgrade to the current
worker0.8.5 — the workspace dependency was capped atworker = "0.7.5"(i.e.>=0.7.5, <0.8), so any consumer sharing multistore's dependency tree was held to 0.7.x. The exact-pin era's blocker (worker 0.7.5+ needs wasm-streams 0.5, which conflicted with the old reqwest 0.12) is gone since #114 moved the tree to object_store 0.14 / reqwest 0.13, so there's no longer a reason to cap the major.How I did it
Cargo.toml— bumpedworker = "0.7.5"→worker = "0.8", letting consumers resolve up to the latest 0.8.x. Rewrote the adjacent comment: it no longer describes a constraint, just records why wasm-streams 0.5 is now satisfiable.Cargo.lock—cargo update -p workerresolved worker/worker-macros/worker-sys to 0.8.5 and pulled the matching wasm-bindgen/web-sys/js-sys/wasm-streams updates. No source changes were required inmultistore-cf-workersor the example.Test plan
cargo check -p multistore-cf-workers --target wasm32-unknown-unknowncargo check -p multistore-cf-workers-example --target wasm32-unknown-unknowncargo check(native workspace)🤖 Generated with Claude Code