Repository navigation
docs(health): gate the tagged-version row on ok:true and data.lastTag - #824
Open
developerz-ai[bot] wants to merge 1 commit into
Open
developerz-ai[bot] wants to merge 1 commit into
developerz-ai[bot] wants to merge 1 commit into
Conversation
A coded refusal (ok:false — 'cannot tell' on a shallow or tagless checkout, 'refused' on a bad flag) emits findings and no data key (lib/log.ts drops an undefined data), so the brief's 'data.reason is not awaiting_tag' test read the row as healthy exactly where the script could not see. The row is answered only when ok:true and data.lastTag are present; a refusal is filed, not satisfied. Dz-Task-Id: tsk_d0027bc6882510780cfd7286112906b8
Contributor
Author
|
Health brief: require ok:true and data.lastTag before reading data.reason
Work landed on #824 — watching it toward merge. 109h30m · 99 tool calls · 40 messages Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-5 (developerz-ai[bot]) · model |
Contributor
Author
|
Waiting on our own review of this head, which is taking too long. Nothing is needed from you right now.
Status for head 🤖 Posted by developerz.ai — an automated agent, not a human. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A coded refusal (ok:false — 'cannot tell' on a shallow or tagless checkout,
'refused' on a bad flag) emits findings and no data key (lib/log.ts drops an
undefined data), so the brief's 'data.reason is not awaiting_tag' test read the
row as healthy exactly where the script could not see. The row is answered only
when ok:true and data.lastTag are present; a refusal is filed, not satisfied.
Acceptance
ok: trueand a presentdata.lastTagok: false, findings, nodata(summariescannot tellandrefused) — as not answered, never satisfieddata.reasononly after the ok:true/data.lastTag guard, and the command cellbun run scripts/release-due.ts --jsonis unchangedChanges
.dz/briefs/health.md(edit) — Reword line 14's Healthy cell (the "the stamped version is tagged" row). Replace its leading sentence "data.reasonis notawaiting_tag." with: "ok: trueanddata.lastTagpresent, withdata.reasonnotawaiting_tag— the row is answered only then. A refusal (ok: false, findings and nodata:cannot tellon a shallow or tagless checkout,refusedon a bad flag) is not answered, never satisfied — file it, with its findings." Leave the command cell and the trailing green-but-untagged sentence unchanged.packages/db/src/schema-load.contract.test.ts(edit) — [docs] minor — the comment added at lines 26-27 asserts "120s — the WASM-boot budgettest-database.test.tspins", but this same diff raises test-database.test.ts:20 to PGLITE_BOOT_MS = 300_000, so the cited number is false as the diff lands (staleness this diff caused). Reword lines 26-27 to stop asserting test-database pins 120s: either drop the number and keep the citation ("in line with the WASM-boot budgettest-database.test.tspins") or cite the actual 300s. Keepconst BOOT_MS = 120_000on line 28 unchanged — it still sits ~3x the ~40s real cost the same comment measures.packages/jobs/src/queue-wake.job.test.ts(edit) — [docs] minor — the comment added at lines 46-47 asserts "test-database.test.tsbudgets the same WASM compile plus initdb at 120s", but this same diff raises test-database.test.ts:20 to PGLITE_BOOT_MS = 300_000, so the cited number is false as the diff lands (staleness this diff caused). Change "at 120s" to "at 300s", or drop the number and cite the file. Keepconst PGLITE_BOOT_MS = 120_000on line 49 unchanged — it stays well above the measured 32-42s boot and matches the ceiling driver-pg-lifecycle.job.test.ts:19 cites from this file.Verification
bun run verifypassed (exit 0) in 52m 18s.🤖 Opened by developerz.ai for task
tsk_d0027bc6882510780cfd7286112906b8on developerz-ai/ultimate.Raised automatically by the
raw_task_triagelane.