Repository navigation
Give Finding.at one meaning: a path an agent can open - #821
developerz-ai[bot] merged 2 commits into
Conversation
…OR regex had a useless \\[ escape inside its\ncharacter class; output.test.ts's imports needed alphabetizing around\nthe ci-log import. Both blocked the gate on lint. The substantive\nFinding.at rework (route URL → meta.route in budgets; gate step\nname → meta.step in verify-merge) landed earlier in this change. Dz-Task-Id: tsk_ebcc39790e2a278ad538998886bb8a1e
|
Give Finding.at one meaning: a path an agent can open
Work landed on #821 — watching it toward merge. 102h42m · 735 tool calls · 451 messages Sessions: coding run 🤖 developerz.ai, an automated agent, not a human — hv-dedicated-1 (developerz-ai[bot]) · model |
✅ Reviewed — nothing blocking0 actionable comment(s) · grounded on your code ⏱ 1m 39s wall clock · 🤖 developerz.ai — automated review, running on your model and your box. |
There was a problem hiding this comment.
Review summary — 13 file(s), 1 finding(s).
Critical 0 · Major 0 · Minor 1 · Nit 0
Completed [bot]: moves route URLs and gate-step names out of Finding.at and adds locator round-trip tests. The CI command still collapses findings with distinct locators.
No findings from: concern-security, concern-tests.
| File | Findings |
|---|---|
packages/cli/src/ci-log.ts |
1 minor |
🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by router/gpt-6.1-sol on box hv-dedicated-1 — 247.1k in / 568 out over 3 calls; cost unknown: no price on record for router/gpt-6.1-sol.
|
Waiting for a review of this head. Nothing is needed from you right now.
Status for head 🤖 Posted by developerz.ai — an automated agent, not a human. |
Follow-up intent: Fix failing CI and review findings on #821 Dz-Task-Id: tsk_a645d43442727aa651ab866c0b2f3d39
There was a problem hiding this comment.
Review summary — 3 file(s), 0 finding(s).
Completed [bot]: shared finding deduplication now preserves distinct paths and gate steps across CI logs, with command-level regression tests. No blocking defects found in the supplied incremental diff.
🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-1 — 70.5k in / 234 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.
Acceptance
atis a path an agent can open — as output.ts:24-25 documents and verify-checks.ts:419-428 enforces; non-path locators live on meta (budgets.ts:140 sets meta.route; verify-merge.ts:165 sets meta.step)at: budgets.ts:139-140 and :157-158 spreadat: fileseparately frommeta: { route: url }; budgets.test.ts:380-381 asserts the same shapeat: verify-merge.test.ts:79 pinsexpect(absent.map((finding) => finding.meta?.['step'])).toEqual(['lint', 'unit', 'live'])[step=...], LOCATOR at ci-log.ts:72 parses(...); both round-trip via renderFinding at output.ts:185-191--jsonshape row documents the new field: findings are{ code, cause, fix, docs?, at?, meta? }(wiki/CLI-Reference.md:22)bun run verifypasses —lint(the remaining lint failures from the prior attempt are gone),typecheck, and the unit covers over ci-log.test, output.test, budgets.test, verify-merge.test, prerender-islands.testChanges
packages/cli/src/ci-log.ts(edit) — Fix lint/complexity/noUselessEscapeInRegex at the STEP_LOCATOR regex (was\[step=([^\[\]]+)\]\s*$): the\[inside the[...]character class is a useless escape. Change the inside to[^[\]]. Keep the literal\[and\]OUTSIDE the class.packages/cli/src/output.test.ts(edit) — Fix biome organizeImports at line 1: theimport { findingsFrom } from './ci-log';block is below the./outputimports but alphabet orders it before./messages. Reorder so./ci-loglands between@ultimat3/coreand./messages.wiki/CLI-Reference.md(edit) — Update--jsonshape row's finding shape from{ code, cause, fix, docs?, at? }to also includemeta?— non-path locators (meta.step,meta.route) live there.Verification
bun run verifypassed (exit 0) in 30m 53s.🤖 Opened by developerz.ai for task
tsk_ebcc39790e2a278ad538998886bb8a1eon developerz-ai/ultimate.Raised automatically by the
raw_task_triagelane.