Skip to content

Give Finding.at one meaning: a path an agent can open - #821

Merged
developerz-ai[bot] merged 2 commits into
mainfrom
dz/give-finding-at-one-meaning-a-path-an-agent-can--ebcc3979
Oct 21, 2026
Merged

developerz-ai[bot] merged 2 commits into
mainfrom
dz/give-finding-at-one-meaning-a-path-an-agent-can--ebcc3979

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Acceptance

  • every Finding's at is a path an agent can open — as output.ts:24-25 documents and verify-checks.ts:419-428 enforces; non-path locators live on meta (budgets.ts:140 sets meta.route; verify-merge.ts:165 sets meta.step)
  • budgets' route URL is no longer in at: budgets.ts:139-140 and :157-158 spread at: file separately from meta: { route: url }; budgets.test.ts:380-381 asserts the same shape
  • verify-merge's gate step name is no longer in at: verify-merge.test.ts:79 pins expect(absent.map((finding) => finding.meta?.['step'])).toEqual(['lint', 'unit', 'live'])
  • ci-log recovers both locators: STEP_LOCATOR at ci-log.ts:77 parses [step=...], LOCATOR at ci-log.ts:72 parses (...); both round-trip via renderFinding at output.ts:185-191
  • wiki's --json shape row documents the new field: findings are { code, cause, fix, docs?, at?, meta? } (wiki/CLI-Reference.md:22)
  • the gate is clean: bun run verify passes — lint (the remaining lint failures from the prior attempt are gone), typecheck, and the unit covers over ci-log.test, output.test, budgets.test, verify-merge.test, prerender-islands.test

Changes

  • packages/cli/src/ci-log.ts (edit) — Fix lint/complexity/noUselessEscapeInRegex at the STEP_LOCATOR regex (was \[step=([^\[\]]+)\]\s*$): the \[ inside the [...] character class is a useless escape. Change the inside to [^[\]]. Keep the literal \[ and \] OUTSIDE the class.
  • packages/cli/src/output.test.ts (edit) — Fix biome organizeImports at line 1: the import { findingsFrom } from './ci-log'; block is below the ./output imports but alphabet orders it before ./messages. Reorder so ./ci-log lands between @ultimat3/core and ./messages.
  • wiki/CLI-Reference.md (edit) — Update --json shape row's finding shape from { code, cause, fix, docs?, at? } to also include meta? — non-path locators (meta.step, meta.route) live there.

Verification

bun run verify passed (exit 0) in 30m 53s.


🤖 Opened by developerz.ai for task tsk_ebcc39790e2a278ad538998886bb8a1e on developerz-ai/ultimate.

Raised automatically by the raw_task_triage lane.

🤖 developerz.ai, an automated agent, not a human — this PR is one slice of a stacked plan.
Dispatched automatically by the raw_task_triage lane
Model MiniMax-M3 on router.ai.developerz.ai via native, funded by account_key
Ran on box hv-dedicated-1
Cost unknown: no list price on record for MiniMax-M3 on router.ai.developerz.ai
Run timeline run_cfb9e609fdfa4d13bc6aa83d4aec8ed4
Part 1/1 of plan rtk_fba9316cf5cd43cb8734f913bcb01f88

…OR regex had a useless \\[ escape inside its\ncharacter class; output.test.ts's imports needed alphabetizing around\nthe ci-log import. Both blocked the gate on lint. The substantive\nFinding.at rework (route URL → meta.route in budgets; gate step\nname → meta.step in verify-merge) landed earlier in this change.

Dz-Task-Id: tsk_ebcc39790e2a278ad538998886bb8a1e
@developerz-ai

developerz-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Give Finding.at one meaning: a path an agent can open

Work landed on #821 — watching it toward merge.

102h42m · 735 tool calls · 451 messages

Sessions: coding run


🤖 developerz.ai, an automated agent, not a human — hv-dedicated-1 (developerz-ai[bot]) · model MiniMax-M3 on router.ai.developerz.ai

@developerz-ai developerz-ai Bot added dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR. labels Oct 21, 2026
@developerz-ai

developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Reviewed — nothing blocking

0 actionable comment(s) · grounded on your code

⏱ 1m 39s wall clock · gpt-6.1-sol via router · 2 model call(s) · 234 output token(s)

🤖 developerz.ai — automated review, running on your model and your box.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 13 file(s), 1 finding(s).

Critical 0 · Major 0 · Minor 1 · Nit 0

Completed [bot]: moves route URLs and gate-step names out of Finding.at and adds locator round-trip tests. The CI command still collapses findings with distinct locators.

No findings from: concern-security, concern-tests.

File Findings
packages/cli/src/ci-log.ts 1 minor

🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by router/gpt-6.1-sol on box hv-dedicated-1 — 247.1k in / 568 out over 3 calls; cost unknown: no price on record for router/gpt-6.1-sol.

Comment thread packages/cli/src/ci-log.ts Outdated
@developerz-ai

developerz-ai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Waiting for a review of this head. Nothing is needed from you right now.

  • Red on this head: no check is failing
  • What was done: CI has finished. No review verdict covers this head yet, or one still holds it.
  • What happens next: The platform asks for its own review when none is coming; a human reviewer who requested changes is waited for. It is handed to a person if nothing arrives.

Status for head 01dfd95a94f3. This comment is updated in place.

🤖 Posted by developerz.ai — an automated agent, not a human.

Follow-up intent: Fix failing CI and review findings on #821

Dz-Task-Id: tsk_a645d43442727aa651ab866c0b2f3d39

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 3 file(s), 0 finding(s).

Completed [bot]: shared finding deduplication now preserves distinct paths and gate steps across CI logs, with command-level regression tests. No blocking defects found in the supplied incremental diff.

🤖 developerz.ai review — automated, running on your model and your box. What is this? · Reviewed by router/gpt-6.1-sol on box hv-dedicated-1 — 70.5k in / 234 out over 2 calls; cost unknown: no price on record for router/gpt-6.1-sol.

@developerz-ai
developerz-ai Bot merged commit c56f7d9 into main Oct 21, 2026
16 checks passed
@developerz-ai
developerz-ai Bot deleted the dz/give-finding-at-one-meaning-a-path-an-agent-can--ebcc3979 branch October 21, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by developerz.ai, an automated agent, from a fleet run. dz/model:MiniMax-M3 developerz.ai: model that wrote this bot PR. dz/provider:router.ai.developerz.ai developerz.ai: provider that served this bot PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants