Skip to content

fix: integrate scanner and widget lifetime corrections on current main - #7

Draft
ellmos-multi-bot wants to merge 4 commits into
mainfrom
multibot/codebox-qt-integration-20261022
Draft

ellmos-multi-bot wants to merge 4 commits into
mainfrom
multibot/codebox-qt-integration-20261022

Conversation

@ellmos-multi-bot

Copy link
Copy Markdown
Contributor

This integrates the independent source fixes from #3 and #5 on current main 60ac993, which already contains merged #6's exclusion of the demonstrated Qt 6.12.0 binding regression. The older PR heads predate that dependency correction and still have failing native checks.

Validation: all three new regression cases fail against current main before integration and all 15 focused scanner/Minimap/ProjectView tests pass after integration. Native Windows Python 3.12.10, PySide6/shiboken6 6.11.1; Ruff and diff checks pass. The full local suite was still running at PR creation, with stack samples showing progress through theme application in successive tests; no full local-suite success is claimed here. Exact-head complete native CI is required before merge.

Head: 8b289f9. Integration author: Codex / GPT-6, session 01a160ec-8a99-7c83-b6e9-01276265c6a8. This Draft needs full independent review by a different instance/session; the integration author will not self-approve or self-merge. Select this corrected integration route or the original PRs, not both. Original author branches remain unchanged. No release or runtime mirror update.

Lukas Geiger and others added 4 commits October 15, 2026 18:36
@github-actions

Copy link
Copy Markdown

Welcome! 👋 Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

@ellmos-multi-bot

Copy link
Copy Markdown
Contributor Author

Author QA update, not an independent approval. Head 8b289f9 remains merge-HOLD.

Current CI 39720458835: Windows/Python 3.10 job 119632528992 installed PySide6/shiboken6 6.11.2 and aborted with a native access violation at tests/test_find_in_files.py:243 (qapp.processEvents() in test_find_in_files_dialog_ui_and_jump). This is distinct from the previously demonstrated Qt 6.12.0 none_dealloc regression already mitigated by merged #6. No cause or fix for this new failure is established. At this snapshot ten CI jobs succeeded and two Windows jobs were still running; Linux/macOS platform smokes also succeeded.

The three source regressions and 15 focused tests are confirmed, but they do not establish full native acceptance. The additional local Windows/Python 3.12/PySide6 6.11.1 suite is still CPU-active, with stack samples showing progress between tests during global theme application; no full-suite success is claimed. It is bounded by the repository's existing 25-minute CI runtime limit. A separate observation of ten searches found all 30 unmodified dialog-handler calls on the GUI thread locally, so no speculative thread-affinity change was made. This does not rule out the Windows-3.10 failure.

Keep this Draft unmerged. Next: read terminal native results, investigate/reproduce the Windows-3.10 failure, and obtain a different-instance full review at the final head. No workflows, dependencies or versions have been changed by this integration, and no tests have been disabled.

@ellmos-multi-bot

Copy link
Copy Markdown
Contributor Author

Terminal author-QA results at unchanged head 8b289f9 (not an independent approval):

  • The local full Windows/Python 3.12.10/PySide6+shiboken 6.11.1 suite finished naturally with 363 passed, one existing opt-in LSP-runtime skip, exit 0, in 1458.74s. The 25-minute watchdog did not terminate it.
  • The initial exact-head GitHub attempt is terminal: 18 successful checks and one failed check. All 11 other native test cells, lint, both platform smokes and CodeQL completed successfully.
  • Windows/Python 3.10 job 119632528992 in CI run 39720458835 installed PySide6+shiboken 6.11.2 and crashed with an access violation during qapp.processEvents() at tests/test_find_in_files.py:243. The successful local run and other platforms do not explain or repair that failure. No rerun was performed and no test was disabled.

The integration therefore remains Draft and merge-HOLD. The next investigation must reproduce/classify that Windows-3.10 crash before claiming complete native acceptance; an independent different-session review is also required. The original #3/#5 branches and current main remain unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant