chore(setup): deprecate 'dhq setup' in favor of 'dhq skills'#30
Conversation
'dhq skills install' supersedes 'dhq setup': it auto-detects installed agents and covers 12 of them, vs the 4 hard-coded subcommands here. The two now overlap, which is confusing. Mark 'dhq setup' deprecated without breaking it: - Each subcommand prints a yellow deprecation warning on every run (stderr, so JSON/data on stdout is unaffected) pointing at the exact equivalent 'dhq skills install --agent <name>'. - Parent and per-agent help text carry a DEPRECATED notice. - README marks 'dhq setup' deprecated in the command list and the Agent Integration section. Behaviour is otherwise unchanged — existing scripts keep working until a future release removes the command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
Changesdhq setup deprecation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa7b067361
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/commands/setup.go`:
- Line 107: The short help for the deprecated setup command points to the wrong
replacement command. Update the Short text in the setup command definition so it
references the actual install subcommand used by the replacement flow, and
verify the wording around the Setup command/help message clearly directs users
from setup to skills install rather than the parent skills command.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6388366d-1ea4-4b3a-aa6e-9c4668ac5f96
📒 Files selected for processing (2)
README.mdinternal/commands/setup.go
…tests Address Review Council findings on PR #30: - The warning no longer overclaims equivalence. 'dhq skills' has no uninstall and installs at each agent's own default scope, so setupDeprecationNote() now branches: * --uninstall -> says there's no 'dhq skills' uninstall yet and that 'dhq setup <agent> --uninstall' stays the removal path; * --project -> notes 'dhq skills' uses the agent's default scope (e.g. Cursor is user-scope there, project-scope here), not project-local; * plain install -> points at 'dhq skills install --agent <name>'. - skills/deployhq/references/auth-setup.md (shipped into agents by 'dhq skills install') led with 'dhq setup' and would teach agents to use the deprecated command. It now leads with 'dhq skills' and marks 'dhq setup' deprecated with the uninstall/scope caveats. - Add internal/commands/setup_test.go: locks the setup->skills name mapping against real registered targets, covers the three message modes, and asserts the warning lands on stderr with stdout left clean. go test ./... -race, go vet, golangci-lint all clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CodeRabbit review on PR #30: the parent command's short help said 'use dhq skills', but the actual replacement is the installing command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Addressed review feedback in 91c58a8:
|
Summary
dhq skills install(merged in #26) supersedesdhq setup: it auto-detects installed agents and covers 12 of them, vs the 4 hard-coded subcommands indhq setup. The two overlap, which is confusing. This deprecatesdhq setupwithout breaking it.dhq setup <agent>subcommand prints a yellow deprecation warning on every run (stderr — stdout JSON/data is unaffected), pointing at the exact equivalentdhq skills install --agent <name>.--helptext carry aDEPRECATEDnotice.dhq setupdeprecated in the command list and the Agent Integration section.Existing scripts keep working until a future release removes the command.
Verification
go build,go vet,go test ./internal/commands/..., andgolangci-lintall pass.🤖 Generated with Claude Code
Summary by CodeRabbit
dhq setup <agent>so the warning is correctly tailored by mode (install/project/uninstall) and points to the matchingdhq skills install --agent <name>target.dhq skills, clearly markingdhq setup <agent>as deprecated with migration guidance.