Skip to content

chore(setup): deprecate 'dhq setup' in favor of 'dhq skills'#30

Merged
facundofarias merged 3 commits into
mainfrom
chore/deprecate-dhq-setup
Jul 1, 2026
Merged

chore(setup): deprecate 'dhq setup' in favor of 'dhq skills'#30
facundofarias merged 3 commits into
mainfrom
chore/deprecate-dhq-setup

Conversation

@facundofarias

@facundofarias facundofarias commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

dhq skills install (merged in #26) supersedes dhq setup: it auto-detects installed agents and covers 12 of them, vs the 4 hard-coded subcommands in dhq setup. The two overlap, which is confusing. This deprecates dhq setup without breaking it.

  • Each dhq setup <agent> subcommand prints a yellow deprecation warning on every run (stderr — stdout JSON/data is unaffected), pointing at the exact equivalent dhq skills install --agent <name>.
  • Parent and per-agent --help text carry a DEPRECATED notice.
  • README marks dhq setup deprecated in the command list and the Agent Integration section.

Existing scripts keep working until a future release removes the command.

Verification

$ dhq setup claude --uninstall
Warning: 'dhq setup' is deprecated; use 'dhq skills install --agent claude-code' instead (auto-detects agents and supports 12 of them). 'dhq setup' will be removed in a future release.
Claude Code integration not found at ~/.claude/skills/deployhq/SKILL.md

go build, go vet, go test ./internal/commands/..., and golangci-lint all pass.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved deprecation messaging for dhq setup <agent> so the warning is correctly tailored by mode (install/project/uninstall) and points to the matching dhq skills install --agent <name> target.
  • Documentation
    • Updated the README and skill auth/setup reference docs to prefer dhq skills, clearly marking dhq setup <agent> as deprecated with migration guidance.
  • Tests
    • Added coverage to verify deprecation hints, output routing (stderr vs stdout), and agent-to-skills target mapping.

'dhq skills install' supersedes 'dhq setup': it auto-detects installed
agents and covers 12 of them, vs the 4 hard-coded subcommands here. The
two now overlap, which is confusing.

Mark 'dhq setup' deprecated without breaking it:
- Each subcommand prints a yellow deprecation warning on every run
  (stderr, so JSON/data on stdout is unaffected) pointing at the exact
  equivalent 'dhq skills install --agent <name>'.
- Parent and per-agent help text carry a DEPRECATED notice.
- README marks 'dhq setup' deprecated in the command list and the Agent
  Integration section.

Behaviour is otherwise unchanged — existing scripts keep working until a
future release removes the command.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e54831b4-37e7-47bb-a161-53572d44db50

📥 Commits

Reviewing files that changed from the base of the PR and between eec549c and 91c58a8.

📒 Files selected for processing (1)
  • internal/commands/setup.go

Walkthrough

dhq setup is marked deprecated in favor of dhq skills install. A new SkillsName field is added to the agentSetup struct and set for supported agents. The command help, runtime warning, tests, and documentation now reference the mapped dhq skills install --agent <name> flow.

Changes

dhq setup deprecation

Layer / File(s) Summary
agentSetup struct and per-agent SkillsName wiring
internal/commands/setup.go
Adds SkillsName to agentSetup and sets it for the supported agent entries.
Command help text and runtime deprecation warning
internal/commands/setup.go
Marks dhq setup as deprecated in command help, emits per-run warnings with the mapped dhq skills install --agent target, and adds the deprecation line to longHelp(a).
Deprecation behavior tests
internal/commands/setup_test.go
Adds tests for SkillsName resolution, mode-aware deprecation text, and stderr/stdout routing for the setup command.
README and reference docs
README.md, skills/deployhq/references/auth-setup.md
Updates the README and agent setup reference to describe dhq setup as deprecated and document dhq skills as the preferred workflow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: deprecating dhq setup in favor of dhq skills.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/deprecate-dhq-setup

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa7b067361

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread internal/commands/setup.go Outdated

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@internal/commands/setup.go`:
- Line 107: The short help for the deprecated setup command points to the wrong
replacement command. Update the Short text in the setup command definition so it
references the actual install subcommand used by the replacement flow, and
verify the wording around the Setup command/help message clearly directs users
from setup to skills install rather than the parent skills command.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6388366d-1ea4-4b3a-aa6e-9c4668ac5f96

📥 Commits

Reviewing files that changed from the base of the PR and between 602e0a1 and fa7b067.

📒 Files selected for processing (2)
  • README.md
  • internal/commands/setup.go

Comment thread internal/commands/setup.go Outdated
facundofarias and others added 2 commits June 30, 2026 16:36
…tests

Address Review Council findings on PR #30:

- The warning no longer overclaims equivalence. 'dhq skills' has no
  uninstall and installs at each agent's own default scope, so
  setupDeprecationNote() now branches:
  * --uninstall -> says there's no 'dhq skills' uninstall yet and that
    'dhq setup <agent> --uninstall' stays the removal path;
  * --project   -> notes 'dhq skills' uses the agent's default scope
    (e.g. Cursor is user-scope there, project-scope here), not project-local;
  * plain install -> points at 'dhq skills install --agent <name>'.
- skills/deployhq/references/auth-setup.md (shipped into agents by
  'dhq skills install') led with 'dhq setup' and would teach agents to use
  the deprecated command. It now leads with 'dhq skills' and marks
  'dhq setup' deprecated with the uninstall/scope caveats.
- Add internal/commands/setup_test.go: locks the setup->skills name
  mapping against real registered targets, covers the three message modes,
  and asserts the warning lands on stderr with stdout left clean.

go test ./... -race, go vet, golangci-lint all clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
CodeRabbit review on PR #30: the parent command's short help said
'use dhq skills', but the actual replacement is the installing command.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@facundofarias

Copy link
Copy Markdown
Contributor Author

Addressed review feedback in 91c58a8:

  • CodeRabbit (setup.go short help): parent Short now points at dhq skills install instead of the bare dhq skills.
  • Codex (--project user-scope mismatch): already addressed in eec549c — the --project branch of the deprecation note now states that dhq skills installs at the agent's own default scope rather than project-local, and does not claim equivalence.

@facundofarias facundofarias merged commit 00822d6 into main Jul 1, 2026
4 checks passed
@facundofarias facundofarias deleted the chore/deprecate-dhq-setup branch July 1, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant