Fix for mermaid rendering when the diagram is initially out of view#29
Open
akh00 wants to merge 1 commit into
Open
Fix for mermaid rendering when the diagram is initially out of view#29akh00 wants to merge 1 commit into
akh00 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mermaid diagrams and remote URL images render asynchronously — their placement has no .path until the render/download completes. process_one skips any placement not near the viewport, and the WinScrolled retry in place_images only re-processes placements that already have a .path. So an async-render placement below the initial viewport is never processed (skipped at setup, ignored by the scroll retry) and stays stuck on the "Rendering mermaid diagram…" placeholder forever — even after scrolling onto it. Static images with a near-top block render fine, which masks the bug
Repro: any markdown where the ```mermaid block sits below the fold; e.g. :MdRender demo inside the small terminal window
Fix: process mermaid_source/src_url placements regardless of viewport (matching what update_images already does); static local images keep the lazy-viewport optimization since they retry correctly on scroll.