Validate task ids and reject dot-segment sync paths#33
Merged
Conversation
Defense-in-depth on top of encodeURIComponent for sync task-id paths:
- taskPathSegment now rejects "." / ".." / empty ids, which encodeURIComponent
leaves untouched and URL normalization would otherwise collapse (e.g.
/tasks/../context -> /context).
- parseTasksJsonl validates any present id against /^[a-f0-9]{32}$/, so a
hostile .delega/tasks.jsonl is rejected at parse time. Absent ids (new local
tasks created on push) are still allowed.
Tests cover path-confusing/malformed ids through the parser and dot-segment
ids through taskPathSegment. 7/7 pass.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defense-in-depth on top of
encodeURIComponentfor sync task-id paths.Findings addressed
encodeURIComponent(".")/("..")are unchanged, so an id of..still produces/tasks/../context, which URL normalization collapses to/contextbefore the request leaves the machine.taskPathSegmentnow rejects./../empty..delega/tasks.jsonl:parseTasksJsonlnow validates any presentidagainst/^[a-f0-9]{32}$/, rejecting a hostile tasks file at parse time. Absent ids (new local tasks created on push) are still allowed.Tests
Path-confusing/malformed ids (
..,../agents,task?x=y, non-hex, empty) through the parser, and dot-segment ids throughtaskPathSegment. 7/7 pass.🤖 Generated with Claude Code