Repository navigation
fix(vocabulary): no definitions of function words (M19c) - #42
Open
jgrodziski wants to merge 5 commits into
Open
jgrodziski wants to merge 5 commits into
jgrodziski wants to merge 5 commits into
Conversation
definitionSpeller and rankedWords leave out FUNCTION_WORDS (articles, pronouns, conjunctions, prepositions, auxiliaries, `not`), whatever class the lists give them: `or` is technical, `all` is domain. The PetClinic run paid for 10 such entries and a glossary entry for `or`. The cloud, the classes and drift are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w
The fingerprint comment said a lexicon correction re-explains exactly the units whose words it changed; through dependencyFingerprints it also re-explains everything that depends on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w
docs/insights.md and the side-car reference say which words explain leaves out: short words, keywords and now function words. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w
The Java fixture's --estimate and --dry-run as they now read: 114 474 prompt and 52 415 completion tokens, $0.0429. Three --dry-run blocks still showed the pre-measurement 41 670 completion tokens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w
PLAN 20.3: the list, what is left off it, no option, and what it costs a paid store (PetClinic: 9 units stale directly, 53 calls in all). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
codegraph | bfe8082 | Commit Preview URL Branch Preview URL |
Nov 03 2026, 11:31 AM |
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventh step of milestone M19c in PLAN.md §20 (word cloud / glossary, #6). Stacked on #40 (itself on #39, #38, #37, #36 and #35): this PR's diff is the five commits after #40.
explainno longer asks a model to define function words:or,of,by,with,all,is. This is fix (e) from the PetClinic findings.Why
The PetClinic run (#40) paid for 10 of its 301 word entries on grammar, plus one module glossary entry:
byfindById,findByLastNameStartingWithwithfindByLastNameStartingWith,loadPetWithVisitambiguous)isisDuplicatePetNameViolationofgetNrOfSpecialtiesallfindAll×2ambiguous)orVIEWS_OWNER_CREATE_OR_UPDATE_FORM,VIEWS_PETS_CREATE_OR_UPDATE_FORMambiguous)The
ownermodule then reconciledorinto a glossary entry, and--polysemylisted it. At ~120 completion tokens per word (#40), the cost is small. The noise in the glossary and the polysemy reader is the real problem.The change
FUNCTION_WORDSis a new export ofdefine.tsin@codegraph/vocabulary, with 60 words:not.definitionSpellerandrankedWordsleave these words out whatever class they get:or,byandisare on the technical list,allandtheare domain.rankedWordsis filtered as well, so the two never disagree.--class, drift and the artifact are unchanged. Every word is still counted and tagged (§20.1). Only what layer 2 asks changes.Worth a look in review
A list, not a fifth class. A
functionclass would have changed:--classand the carriers route;all for a question only
explainasks. The cost of that choice: in the cloud,theandallstaydomainandorstaystechnical.What is deliberately not on the list: words that name a thing as often as they join two:
no(a number:orderNo);mayandwill;outofcheckOut,upofsignUp);before,after,between).The list is English only:
duingetNomDuClientis still asked. It is contestable, likeDEFAULT_TECHNICAL.No option to override it.
explaintakes no technical list either. A correction is a code change, and the fingerprint shows what it touches.⚠ What it costs a store already paid for. The asked words are part of the fingerprint. A unit whose names spell a function word goes stale, and through the Merkle chain so does every unit that depends on it. On PetClinic (a copy of the paid store,
--dry-run):…_OR_…view field. The other 44 are stale through their dependencies.Nothing is lost before the next run. The old records stay, and the readers show their
orentries until those are replaced.The fingerprint comment was wrong about this. It said a lexicon correction "re-explains exactly the units whose words it changed". It now says the change also reaches the units' dependents (its own commit).
Docs
docs/insights.mdand the side-car reference say function words are not asked.--estimateand--dry-runare reprinted on four website pages: 114 474 prompt and 52 415 completion tokens, $0.0429 (was 114 483 / 52 900 / $0.0432).--dry-runblocks (reference explain, how-to Estimate the cost, the explain tutorial) still showed the pre-measurement~41670 completion tokens.Verification
["shop", "day", "of", "the"]), then passed.rankedWordsalone fails "lists no function word, so a glossary is not cut on one".unknown output format "llms", pnpm -r build fails on a fresh clone: unknown output format "llms" for kind "home" #23)../build.sh --ts --seapasses its smoke gates ("all gates passed").scale.test.ts, which timed out under the full parallel run and passes alone (the known flake; the analyzer is untouched).--dry-runon a copy of the store, with the base branch's speller as control (0 stale). The paid store in~/spring-petclinicwas not opened by this branch.Still owed for M19c:
docs/vocabulary.mdand the README;Part of #6.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PKCVgyop39vhNa45r7zM8w