Fix all the Must Fix starting defold 1.10.0#663
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50211648ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| *Max Dynamic Textures* | ||
| : The maximum number of textures that can be created using [`gui.new_texture()`](/ref/stable/gui/#gui.new_texture:texture_id-width-height-type-buffer-flip) | ||
| : The maximum number of dynamic textures tracked by this GUI component, `128` by default. This includes textures created with [`gui.new_texture()`](/ref/stable/gui/#gui.new_texture:texture_id-width-height-type-buffer-flip) and external textures assigned to the GUI with `go.set(..., "textures", ...)` or `gui.set(..., "textures", ...)`. Projects that replace many external textures may need to raise this limit. |
There was a problem hiding this comment.
Remove the nonexistent gui.set texture API
When readers try to replace external GUI textures using this new guidance, gui.set(...) is not a GUI Lua API, so that call will fail at runtime instead of updating the component. The supported component property path here is the go.set(..., "textures", ...) form (or the existing GUI texture-specific APIs), so listing gui.set gives users an unusable migration path.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
actually it is possible : https://defold.com/ref/stable/gui-lua/#gui.set:node-property-value-options
No description provided.