chore(registry): update audit + CONTRIBUTING to cover drift script - #4
Merged
Merged
Conversation
…post-PR-3 state Two small follow-ups post PR #3: 1. CONTRIBUTING: steps 7 and 8 added — extending the 'Adding a new ds-* component' flow with (a) updating docs/registry/audit-YYYY-MM-DD.json so the drift CI job has per-item paths and classifications, and (b) running the drift script locally before pushing. Without step 7, adding a new item would land with a red drift job that nobody had warned the contributor about. 2. Audit JSON: version bumped to 2026-07-29-b, ds-colored-badge fields updated to reflect the post-fix state: - concrete-divergence-observed: false (d90b7d9 + e2e47a4 resolved both the structural divergence and the bg-blue-500 -> bg-blue-600 shade bump across both trees) - divergence-detail expanded to explain the showcase and consumer render targets and the equivalent visual classes - per-check updated from FAIL to structural-pass-via-inline - concrete-divergence-resolved-by field lists the two commits that resolved it No code change. CI excludes drift, lint, typecheck, contract, registry-validate, build-showcase all unaffected by doc-only edits. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small doc updates post PR #3, both addressing gaps the
drift script reveals about contributor onboarding.
What's in this PR
1. CONTRIBUTING.md — steps 7 & 8 in the addition flow
Adding a new
ds-*component without updating the auditJSON would land with a red
driftCI job that thecontributor can't debug (it fails closed for un-audited
items). Step 7 makes the audit update part of the
addition flow:
{ "items": { "ds-<id>": { "showcase-category": "shim", "consumer-path": "registry/base-nova/ds-<id>/ds-<id>.tsx", "showcase-path": "packages/registry/src/components/<id>/index.tsx", "workspace-source-path": "packages/ui/src/components/<id>.tsx" } } }Step 8 ("run the drift script locally") catches drift
between the new consumer source and the showcase tree
before pushing — saves a CI round-trip and a clean-up
commit.
2. docs/registry/audit-2026-07-29.json — version bump + state update
Bumped from
2026-07-29to2026-07-29-b. Theds-colored-badgeentry is updated to reflect thepost-fix state (PR #3 commits d90b7d9 and e2e47a4):
concrete-divergence-observed: falseconcrete-divergence-resolved-byfielddivergence-detaildocuments what the showcase andconsumer now render (still Badge primitive vs raw span,
but the span inlines the Badge's class strings so they
produce visually equivalent output)
per-checkandrecommended-fixreflect the newstate (no fix needed; drift script will catch future
silent drift)
CI: unchanged. Doc-only edits do not affect the registry
catalog, the build pipeline, the drift script, or any of
the 6 CI jobs. All 5 of the existing jobs should report
green on this PR (the 6th, drift, runs in 10s and exits 0).
🤖 Generated with Claude Code