Skip to content

ci(release): remove 'version bump' label gate - #41

Merged
codewizdave merged 1 commit into
stagingfrom
docs/release-system-plan
Aug 3, 2026
Merged

ci(release): remove 'version bump' label gate#41
codewizdave merged 1 commit into
stagingfrom
docs/release-system-plan

Conversation

@martyy-code

Copy link
Copy Markdown
Contributor

Summary

Follow-up to PR #40. Removes the version bump label gate from the release workflow. Every PR merged to main now produces a release if it contains .changeset/*.md in its diff.

Why

PR #40 left the label gate in place. The release engineer still had to remember to apply the version bump label on every release PR. That is cognitive load with no safety benefit — the has_changesets detection step already makes merges-without-changesets a no-op. Removing the label simplifies the flow.

What changes

  • .github/workflows/release.yml — drop the contains(..., labels.*.name, 'version bump') condition. PR-closed-on-main is the only condition.
  • CLAUDE.md — update Branching Strategy.
  • CONTRIBUTING.md — same.
  • docs/internal/engineering/plans/release-system.md — update Section 3, Decision log, and YAML example to match the simplified flow.
  • .changeset/remove-version-bump-label.md — required by the ci.yml lint.

Effect

Before: a merge to main without the version bump label is silent.
After: a merge to main with at least one .changeset/*.md publishes a release. A merge without changesets is still a no-op.

🤖 Generated with Claude Code

… main

Simplifies the release flow. Any PR merged to main now produces a
release if it contains .changeset/*.md in its diff. The 'version bump'
label is no longer required.

Changes:
- release.yml: drop the 'contains(..., labels.*.name, "version bump")'
  condition from the job 'if'. PR-closed-on-main is the only condition.
- CLAUDE.md: update Branching Strategy to drop the label requirement.
- CONTRIBUTING.md: same.
- release-system.md (plan): update Section 3, Decision log, and YAML
  example to match the simplified flow.

The 'has_changesets' detection step is the only safety net: a merge
to main without changesets is a no-op (the publish steps are gated
on it). Adds a changeset to pass the new ci.yml lint.
@codewizdave
codewizdave merged commit fa1fd12 into staging Aug 3, 2026
5 checks passed
martyy-code added a commit that referenced this pull request Aug 3, 2026
…ronment)

Adds Section 7 (Trusted publishing & environment) to the plan and a
matching Appendix C (Post-plan decision log). Two items are added to
the Definition of done:

- At least one release has been published via npm trusted publishing
  (OIDC), per Section 7.1.
- The GitHub 'release' environment exists with at least one deployment
  record, per Section 7.2.

Plan Status also moves from 'Proposed' to 'Approved and partially
implemented on staging' because Phases 3, 4, 5 plus Section 7 are now
merged on the staging branch (PRs #40, #41, #42).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants