Repository navigation
chore(template): conform to the DeesseJS template standard v1 - #13
Open
martyy-code wants to merge 3 commits into
Open
martyy-code wants to merge 3 commits into
martyy-code wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
|
…hema Rule 25 bis of the template standard. The workflow fetches the schema from the parent template and validates deesse-template.json with a pinned validator, so a manifest that drifts fails the pull request instead of the catalogue. Co-Authored-By: Claude Code <noreply@anthropic.com>
Two fixes on the manifest validation workflow. The schema is fetched from the main branch of the parent template first and falls back on the branch that carries the standard, so the check works before the standard pull request lands. The automatic package manager cache of the setup node action is off. The workflow installs nothing, and the action was running the package manager to find its store path. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request does
Applies the first tranche of the DeesseJS template standard, version 1.4, to
documentation-template. The standard lives in the parent template, intemplates/standard/template-standard-v1.md.The manifest
deesse-template.jsonis added at the root of the repository. It is the machine readable contract of the template. It declares the technical fields owned by the Head of Templates, and the product fields owned by the Chief Product Officer.namedocumentation-templateslugdocs-startertitletypetemplate:starterlicenserequires.node>=22requires.packageManagerpnpm@11.0.0product.layeropen-communityproduct.categorydocsproduct.labelsfumadocs,mdx,nextjs,llmsThe manifest validates against the schema published by the parent template, at
templates/schema/template-v2.jsonin thedeessejsrepository. The validation runs on every pull request and on every push tomain, in themanifest.ymlworkflow, with a pinned validator. The command isnpx --yes ajv-cli@5.0.0 validate -s template-v2.json -d deesse-template.json, and it passes on this file.The rules applied
actions/checkoutandactions/setup-nodemove from version 4 to version 5 in every workflow.github/dependabot.ymlis present, with a weekly schedule, a pull request limit and a group for the shared dependencies.claude/settings.local.jsonand.claude/worktrees/are removed from the index and added to.gitignoremanifest.ymlworkflow, with a pinned validator, reading the schema from the parent templateThe files in this pull request
.claude/settings.local.json.github/dependabot.yml.github/workflows/manifest.yml.gitignoredeesse-template.jsonpackage.jsonWhat this pull request does not do
It does not merge, it does not publish a release, it does not change the organisation settings, it does not change the
is_templateflag, it does not archive or delete anything, and it does not change the branch protection. The pull request is open for review by the Head of Engineering and by the Head of Templates.Known gaps
These are recorded in the conformance matrix with an owner and a target date. They are the second tranche, and they are not in this pull request.
build.yaml,lint.yamlandtypes.yamlinstead of theci.ymlandrelease.ymlpair. The consolidation lands in the next pull request.format,format:check,type-check,test,test:coverageandsetupare missing at the root, and the type check script is namedtypes:check..github/CODEOWNERSand.github/PULL_REQUEST_TEMPLATE.mdare missing. The governance file set is completed in the next pull request.is_templateflag is still false.format:checkscript and the lint job step land in the next tranche.The standard
The full standard, version 1.4, is in the parent template, in
templates/standard/template-standard-v1.md, and the schema is intemplates/schema/template-v2.json.🤖 Generated with Claude Code