Add keyword argument support to activation checkpointing - #8182
Draft
zupengwang wants to merge 1 commit into
Draft
Add keyword argument support to activation checkpointing#8182zupengwang wants to merge 1 commit into
zupengwang wants to merge 1 commit into
Conversation
Signed-off-by: Wang Zupeng <zupenwang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepSpeed's activation checkpointing wrapper currently accepts positional
arguments only, while
torch.utils.checkpoint.checkpointalso supports keywordarguments. This change allows callers to pass keyword arguments through
deepspeed.checkpointing.checkpoint.Keyword names and non-Tensor values are retained for reconstruction during the
forward and recompute passes. Tensor keyword values are flattened into the
inputs passed to
CheckpointFunction, so autograd tracks them and returns theirgradients correctly.
The activation checkpointing documentation now describes keyword argument
support, and the regression test covers both Tensor and non-Tensor keyword
arguments as well as gradient propagation.
Validation
zero maximum gradient error
with zero maximum gradient error
Fixes #7038