Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tomaskislan/app-preview-runs #620 +/- ##
============================================================
Coverage 39% 39%
============================================================
Files 834 834
Lines 42110 42147 +37
Branches 9246 9255 +9
============================================================
+ Hits 16581 16618 +37
Misses 23431 23431
Partials 2098 2098
🚀 New features to boost your workflow:
|
tkislan
force-pushed
the
tomaskislan/app-preview-runs
branch
from
November 16, 2026 07:21
1e619c2 to
b8f166d
Compare
tkislan
force-pushed
the
tomaskislan/app-preview-app-data
branch
from
November 16, 2026 07:21
69bba98 to
8752d8a
Compare
GET /notebooks/:notebookId/app-data now answers from the newest successful
preview run of the notebook, with Deepnote's body { appData,
agentBlockSummary, runCreatedAt } and its two 404 messages. appData is the
first application/json output that is an object. The agent summary is the
first agent block's markdown, or its stream text, since runtime-core emits an
agent's answer as stream output.
dataframe() is now the only stub that warns.
A new test previews a page that calls appData() before a run, which rejects with Deepnote's no-results message, then run(), then appData() again, which answers the run's JSON output and its createdAt. The shared fixture page now calls dataframe() twice instead of appData(), so the warn-once checks use the only stub left. The apps those checks preview hold a project, so dataframe() reaches the preview; the inputs test checks the in-page rejection of an app without one.
Pin how appData() picks its run with a test that drives runs through POST /runs: it answers the newest started successful run, not the one that finished last, and skips a run still in flight. Wrap isObject in a guard typed as Record<string, unknown>. Its own `obj is any` guard turned off type checking in the functions that build the appData() body.
tkislan
force-pushed
the
tomaskislan/app-preview-app-data
branch
from
November 18, 2026 15:52
8752d8a to
bdaf545
Compare
tkislan
force-pushed
the
tomaskislan/app-preview-runs
branch
from
November 18, 2026 15:52
b8f166d to
8fb1292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai ignore
Summary
In the app preview, a page's
appData()answers from that notebook's newest successfulrun()in the preview, instead of "not supported". Pages can then show the last results on load without running anything.Changes
GET /v2/notebooks/:notebookId/app-datareads the run store and picks the notebook's newest successful run, bycreatedAt. It answers Deepnote's body:appData: the firstapplication/jsonoutput that is a JSON object (not an array, notnull), across blocks and their outputs in order.agentBlockSummary: the first agent block's markdown output; else its stream text, which is how runtime-core emits an agent's answer; elsenull.runCreatedAt: the run's creation time.You have no run results for this notebook yet. Run the notebook to load them.;Your latest run has no JSON output.;Notebook not found.Testing
nullskipped;null;appPreviewgroup:appData()rejects before a run. After a successfulrun(), it returns the run's JSON object andrunCreatedAt.dataframe()'s route, which the bundled copy of Deepnote's client never calls, so no page can reach it. The warning stays covered by unit tests.Notes
clear_outputandupdate_display_data, so a block that redraws its JSON answers with its first version.Stacked on #619.