Skip to content

ci: lock GitHub Actions dependencies - #150

Merged
jamesbhobbs merged 1 commit into
mainfrom
jh/actions-lock
Nov 16, 2026
Merged

jamesbhobbs merged 1 commit into
mainfrom
jh/actions-lock

Conversation

@jamesbhobbs

Copy link
Copy Markdown
Member

Summary

  • add a generated GitHub Actions dependency lockfile
  • migrate repository-local actions to lock-aware $/… references
  • add CI verification to prevent lockfile drift
  • pin Renovate's lockfile updater to gh-actions-lock v0.4.1

Verification

  • gh actions-lock --verify (all 4 workflows valid)
  • renovate-config-validator renovate.json
  • git diff --check

Existing warnings

  • the PyPI publishing action generates a workspace-local helper internally
  • three existing action commits have no tagged release
  • the existing Semgrep container image is not pinned by digest

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CI and CD workflows replace many SHA-pinned third-party action references with version tags and update local action paths. A new workflow runs gh actions-lock --verify on pull requests and pushes to main. Renovate sets the ghActionsLock constraint to v0.4.1.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested reviewers: mfranczel

Merge Risk: Minimal · up to 4a68a

This change locks GitHub Actions dependencies and adds a CI check for lockfile drift. No concrete merge-blocking risk was found in the supplied evidence. The CD build failure is in the Python 3.14 Docker build step and was not tied to these changes.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed Title is concise and specific. It names the main change: locking GitHub Actions dependencies. The changeset adds a generated lockfile, migrates local action references, adds verification, and pins the…
Description check Passed Description lists the lockfile addition, the $/ reference migration, the CI drift check, and the Renovate pin. It also gives verification steps and existing warnings. These match the changeset and obj…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Updates Docs Passed The check applies when a feature is implemented. PR #150 (author jamesbhobbs) is CI and dependency tooling only. The changed files are .github/actions/push-oci-artifact/action.yml, `.github/actions/…
Full details: Title check

Explanation

Title is concise and specific. It names the main change: locking GitHub Actions dependencies. The changeset adds a generated lockfile, migrates local action references, adds verification, and pins the Renovate updater, all of which fit this title.

Full details: Description check

Explanation

Description lists the lockfile addition, the $/ reference migration, the CI drift check, and the Renovate pin. It also gives verification steps and existing warnings. These match the changeset and objectives.

Full details: Updates Docs

Explanation

The check applies when a feature is implemented. PR #150 (author jamesbhobbs) is CI and dependency tooling only. The changed files are .github/actions/push-oci-artifact/action.yml, .github/actions/upload-bundle-artifacts/action.yml, .github/workflows/actions.lock (added), .github/workflows/cd.yml, .github/workflows/ci.yml, .github/workflows/verify-actions-lock.yml (added), and renovate.json. None of these add or change product behavior. The PR changes action pins, adds a lockfile, adds a verification workflow, and pins the Renovate updater. The check is therefore inapplicable. No documentation update is required for this PR, and the reminder to update the external deepnote/deepnote docs or the deepnote-internal roadmap is not triggered.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: f331b288-fea5-4622-a9ac-0ea7f7af83d0
Commits

Reviewing files that changed from the base of the PR and between 6523327 and 4a68a4b.

Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock
Files selected for processing: 6

  • .github/actions/push-oci-artifact/action.yml
  • .github/actions/upload-bundle-artifacts/action.yml
  • .github/workflows/cd.yml
  • .github/workflows/ci.yml
  • .github/workflows/verify-actions-lock.yml
  • renovate.json

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

@github-actions

Copy link
Copy Markdown

📦 Python package built successfully!

  • Version: 2.9.1.dev3+306ca3e
  • Wheel: deepnote_toolkit-2.9.1.dev3+306ca3e-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/2.9.1.dev3%2B306ca3e/deepnote_toolkit-2.9.1.dev3%2B306ca3e-py3-none-any.whl"

@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.43%. Comparing base (6523327) to head (4a68a4b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   78.43%   78.43%           
=======================================
  Files         121      121           
  Lines        6920     6920           
  Branches     1005     1005           
=======================================
  Hits         5428     5428           
  Misses       1182     1182           
  Partials      310      310           
Flag Coverage Δ
combined 78.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@jamesbhobbs
jamesbhobbs requested a review from m1so November 12, 2026 21:36
@jamesbhobbs
jamesbhobbs marked this pull request as ready for review November 13, 2026 16:54
@jamesbhobbs
jamesbhobbs requested a review from a team as a code owner November 13, 2026 16:54
@jamesbhobbs
jamesbhobbs merged commit 0b0d0ab into main Nov 16, 2026
43 of 45 checks passed
@jamesbhobbs
jamesbhobbs deleted the jh/actions-lock branch November 16, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants