Repository navigation
fix(pt): fall back to single-rank .pt2 when the optional with-comm artifact export fails #6027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Fillianore
wants to merge
4
commits into
deepmodeling:master
from
Fillianore:fix/pt-freeze-with-comm-fallback
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
170dbd6
fix(pt): fall back to single-rank .pt2 when with-comm export fails
Fillianore 0024148
test(pt): cover the with-comm export failure fallback in SeZM freeze
Fillianore 9c99867
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 69d627c
Merge branch 'master' into fix/pt-freeze-with-comm-fallback
OutisLi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Add regression coverage for the with-comm export failure. The current tests cover successful artifact export and non-applicable
has_comm_artifact=falsecases, but none makes_export_with_comm_artifactraise through this caller. Add a focused test that forces the exception, freezes the model, assertshas_comm_artifactis false, checks thatmodel/extra/forward_lower_with_comm.pt2is absent, and loads the archive in single-rank mode.🧰 Tools
🪛 ast-grep (0.45.3)
[info] 1115-1115: use jsonify instead of json.dumps for JSON output
Context: json.dumps(metadata)
Note: [CWE-116] Improper Encoding or Escaping of Output.
(use-jsonify)
🤖 Prompt for AI Agents