Repository navigation
CMake: Prepare test scripts and data at configure time - #8161
Conversation
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review completed at a5d72ec6; no confirmed implementation defect was found.
Non-blocking: Please add the exact configure/build/CTest commands and observed results to the PR description, including CTest without installation and any resource-refresh or multi-config cases checked; explicitly note untested combinations. A small regression check for abacus_copy_test_files can follow after merge.
Builds/runtime tests were not run, and CI verification was unavailable.
I modified the Test workflow so the results should be clear in CI. For developers/users, nothing to adjust, but they can now run |
|
@ABACUS-PR-BOT Please take a final review on this PR. |
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review completed at 5abca36b; no confirmed implementation defect was found.
Non-blocking: Please update the unit-test instructions in docs/CONTRIBUTING.md:295-308 and docs/advanced/install.md:114: resources are now staged at configure time, so installation is no longer required before CTest. This documentation cleanup can follow after merge.
git diff --check and Bash syntax checks for all 26 changed scripts passed. Builds/runtime tests were not run, and CI verification was unavailable.
Prepare test scripts and data at configure time so CTest can run directly after building but before installing.