Repository navigation
refactor(deltaspin): encapsulate ScState lambda and Mi - #8112
Merged
mohanchen merged 4 commits intoOct 10, 2026
Merged
Conversation
mohanchen
approved these changes
Oct 10, 2026
mohanchen
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR encapsulates
ScState::lambda_andScState::Mi_as private members, adds mutableaccessors, and updates all affected DeltaSpin call sites.
Motivation
The change improves data encapsulation and makes read-
only and writable access explicit. Read-only call sites
now use the existing const getters, while mutation sites
use the new mutable accessors.
Verification
git diff --checkpassed.global dependency count, existing test coverage without
new test files, and no documentation update for this
internal refactor.
Behavior
This PR does not modify the DeltaSpin numerical
algorithm, physical calculation logic, formulas, loop
behavior, or numerical parameters.