Repository navigation
Refactor Parallel_Grid::init into serial/parallel subroutines - #8111
Merged
Merged
Conversation
Agent Governance Check
|
MrLi000001
force-pushed
the
refactor-parallel-grid-init
branch
from
October 10, 2026 03:22
980aa54 to
94c7126
Compare
mohanchen
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation The original Parallel_Grid::init used an in-function #ifndef __MPI ... return; guard, which effectively split the function into two halves. Readers had to infer that "the serial build stops here while the parallel build continues", violating clear control-flow and increasing maintenance burden.
Changes
Split the original init into two single-responsibility functions:
init_serial(...): assigns dimension members, validates nczp < 0, asserts sizes, and computes ncxy/ncxyz (shared by both builds).
init_parallel(nprocgroup): partitions processes across Pools by KPAR, allocates numz/startz/whichpro/whichpro_loc, and calls z_distribution().
The new init(...) orchestrates both: calls init_serial always, then init_parallel under #ifdef __MPI.
Removed the old init implementation and a now-stale comment, eliminating the mid-function #ifndef __MPI early return.
Added init_serial / init_parallel private declarations to the header.
Result
Logically equivalent; behavior is unchanged.
Serial vs. parallel code paths are now clearly separated, improving readability and maintainability.
Testing
Serial build (-DENABLE_MPI=OFF) passes
Parallel build (-DENABLE_MPI=ON) passes