Repository navigation
fix(esolver): sort DeePMD MD neighbors by distance - #8104
Merged
Merged
Conversation
This was referenced Oct 10, 2026
mohanchen
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.Linked Issue
Fixes #8071
Unit Tests and/or Case Tests for my changes
Commands run:
cmake -S . -B build_issue8071 \ -DENABLE_MPI=ON \ -DENABLE_LCAO=OFF \ -DENABLE_OPENMP=OFF \ -DBUILD_TESTING=ON \ -DGIT_SUBMODULE=OFF CCACHE_DISABLE=1 cmake --build build_issue8071 \ --target MODULE_ESOLVER_esolver_dp_test -j2 OMP_NUM_THREADS=1 ctest --test-dir build_issue8071 -V \ -R MODULE_ESOLVER_esolver_dp_testThe issue reproduction was also run with the provided DeepMD comparison script:
PYTHONPATH=/tmp/issue8071_pydeps
LD_LIBRARY_PATH=/tmp/mpichvenv/lib:/tmp/issue8071_pydeps
TF_INTRA_OP_PARALLELISM_THREADS=1
TF_INTER_OP_PARALLELISM_THREADS=1
OMP_NUM_THREADS=1
python3 compare_issue8071.py . frozen_seed1.pth
The modified esolver_dp.cpp and the new unit test compile successfully.
The reproduction confirms that the original neighbor ordering causes:
RMSE = 1.6590e-02
MAX = 7.0008e-02
Sorting neighbors by distance reduces the discrepancy to:
RMSE = 1.8392e-05
MAX = 6.0702e-05
The root cause reported in issue [Bug] v3.11.0-beta10: esolver_type=dp forces deviate from model predictions (MDCell neighbor-list path) #8071 is therefore confirmed.
The CTest executable could not start because of a local BLAS/ScaLAPACK runtime conflict:
libblas.so.3: undefined symbol: gotoblas
The DeePMD-enabled test target reached compilation of the modified production source, but final linking was blocked by the locally installed DeePMD 2.2.11/TensorFlow dependency setup.
What's changed?
Governance Notes