Skip to content

Prevent dependency building failure in Intel Dockerfile - #7741

Open
Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:docker-current
Open

Prevent dependency building failure in Intel Dockerfile#7741
Growl1234 wants to merge 1 commit into
deepmodeling:developfrom
Growl1234:docker-current

Conversation

@Growl1234

Copy link
Copy Markdown

Currently Intel Dockerfiles fails because Intel oneAPI toolkit lefts an invalid mpiifort wrapper that generates ifort command which doesn't exist in Intel oneAPI 2025.2; same as mpiicc and mpiicpc. This PR explicity set compilers to mpiicx, mpiicpx, and mpiifx through Docker's ENV.

Also, adds fail-fast: false to the workflow files with several jobs so that the jobs that should be successful are not interrupted by a single failing job.

Copilot AI review requested due to automatic review settings August 1, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Intel oneAPI 2025.2 container build breakage by explicitly selecting the new Intel MPI compiler wrappers, and improves CI signal by preventing matrix jobs from being canceled early when one job fails.

Changes:

  • Set CC/CXX/FC in Dockerfile.intel to mpiicx/mpiicpx/mpiifx (and install ca-certificates).
  • Add strategy.fail-fast: false to selected multi-job GitHub Actions workflows so independent jobs continue running.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Dockerfile.intel Pins MPI compiler wrappers via environment variables to avoid broken legacy wrapper defaults in oneAPI 2025.2.
.github/workflows/devcontainer.yml Disables matrix fail-fast so other container builds proceed even if one fails.
.github/workflows/build_test_cmake.yml Disables matrix fail-fast so other build configurations proceed even if one fails.

Comment thread Dockerfile.intel
Copilot AI review requested due to automatic review settings August 1, 2026 10:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@mohanchen mohanchen added the Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS label Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants