fix(vm): respect node placement when picking TSC frequency#2630
Merged
Conversation
2d0f2a3 to
ad96a8f
Compare
added 6 commits
July 14, 2026 14:21
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
5d0b866 to
244ca42
Compare
diafour
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
3p-kubevirttov1.6.2-v12n.60. The only change here is the fork tag inbuild/components/versions.yml; the actual fix lives in the fork.The fork now picks the invariant TSC frequency for a VMI only among the nodes that VMI can actually be scheduled on (the pod's nodeSelectors + required node affinity), instead of the cluster-wide minimum.
Fork PR: deckhouse/3p-kubevirt#150
Why do we need it, and what problem does it solve?
VMs that require a pinned TSC frequency — Windows guests (Hyper-V Reenlightenment, enabled automatically for
osType: Windows) orinvtsc: require— could hang inPendingforever.The frequency was chosen as the minimum across all schedulable nodes. If that minimum belonged to a node the VM cannot land on (excluded by VMClass CPU-feature selectors,
nodeSelectoror affinity), and the candidate nodes are non-scalable with that frequency outside the ±250 ppm tolerance, the pod'stsc-frequency-<F>selector never intersects with the rest of its selectors. The pod staysPending, and since hints are written to the VMI once, it never recovers on its own. Breaks on heterogeneous clusters with per-VM placement constraints.What is the expected result?
A Windows VM on a VMClass restricted to a subset of nodes gets a TSC frequency native to one of its candidate nodes and schedules normally. Reproduction steps and the behavior matrix are in the fork PR.
Checklist
Changelog entries