[feature] add OnBeforeDeleteHelm binding to module hook config#104
Merged
Conversation
This was referenced Apr 27, 2026
ipaqsa
approved these changes
Jul 10, 2026
ipaqsa
changed the title
Signed-off-by: Artem Kuleshov <artem.kuleshov@flant.com>
Fkuloff
force-pushed
the
feature/before-delete-helm
branch
from
3fb0594 to
9055735
Compare
ldmonster
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
OnBeforeDeleteHelmto module hook configuration so a hook authored with module-sdk can register for the newbeforeDeleteHelmlifecycle binding (fires just beforehelm uninstallof a module's release). Mirrors the existingOnAfterDeleteHelmeverywhere it appears.pkg/hook.go— new*OrderedConfigfield inHookConfigandApplicationHookConfigpkg/hook/dto.go— DTO field withyaml/json:"beforeDeleteHelm,omitempty"internal/controller/controller.go— conversion inremapModuleHookConfigandremapApplicationHookConfig