Repository navigation
docs: decdn's sign-release.sh, not publish-crates.sh, runs open-decdn-bump.sh - #200
Merged
Merged
Conversation
…-bump.sh decdn/decdn#2816 deleted publish-crates.sh; sign-release.sh now opens the bump PR once the release is out of draft. The invocation is unchanged. Closes #198 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the documentation updates clarifying the release-bump caller and timing.
No open issues 🎉
What changed in this PR
Updates documentation to reflect that upstream sign-release.sh now invokes the devops bump script, addressing #198. No executable code or invocation arguments change.
Changes:
- Replaces references to
publish-crates.shwithsign-release.shin three locations. - Clarifies in the script header that the bump runs after the release leaves draft status.
| File | Description |
|---|---|
scripts/open-decdn-bump.sh |
Corrects the header comment’s caller and release timing. |
ansible/roles/decdn_node/README.md |
Names the current caller in the release-bumping instructions. |
AGENTS.md |
Updates the caller named in the pinned-release guidance. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decdn/decdn#2816 (merged) deleted decdn's
scripts/publish-crates.sh. The devops bump PR is now opened at the end of decdn'sscripts/sign-release.sh, once the release is out of draft. The crates.io upload moved topublish-crates.yml, which devops does not depend on.This PR renames the script in the three places that named the old one:
scripts/open-decdn-bump.shheader commentAGENTS.mdpinned-releases paragraphansible/roles/decdn_node/README.md§ Bumping the decdn releaseThe script is still called the same way: one tag, from a fresh clone of devops
main. The fleet's vendored copy of the role README picks up the change at the nextdecdn.noderelease.make lintandmake test-scriptspass.Closes #198
🤖 Generated with Claude Code