fix: merge namespaces in enable() instead of flushing them - #1050
Open
arronKler wants to merge 1 commit into
Open
fix: merge namespaces in enable() instead of flushing them#1050arronKler wants to merge 1 commit into
arronKler wants to merge 1 commit into
Conversation
enable() currently wipes names/skips, so DEBUG=foo followed by
enable("bar") disables foo. Merge incoming namespaces with the
existing set. Call disable() first when replacement is intended.
Fixes debug-js#425
official-burak
left a comment
official-burak
left a comment
There was a problem hiding this comment.
enable() is documented as a full replace, including the DEBUG=foo example this PR rewrites. Code that calls debug.enable('production') today relies on that to drop whatever DEBUG was. Making it additive would keep those namespaces on, which is a behavior change rather than a bugfix.
If additive enable is useful, it needs a new method or an opt-in, not a silent change to enable().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug.enable()currently clearsnames/skipsbefore applying the new list. That means previously enabled namespaces (including those fromDEBUG) disappear:This also breaks independent
enable()calls from different modules that share onedebuginstall.Solution: treat
enable()as additive. Incoming namespaces are merged with the existing set (skip tokens still disable a matching name; enabling a name again removes its skip).disable()still clears everything and is the way to replace:Fixes #425