Use American spelling in Honour/initialise test names - #389
Merged
tameware merged 6 commits intoSep 19, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments; changes are limited to test names and documentation.
Pull request overview
Updates test identifiers and documentation to use American spelling without changing public APIs.
Changes:
- Renamed remaining test identifiers.
- Updated the solver-context specification citation.
- Preserved public API names.
File summaries
| File | Description |
|---|---|
specs/solver-context.md |
Updated the test citation. |
library/tests/trans_table/trans_table_p_test.cpp |
Renamed a test identifier. |
library/tests/system/worker_count_test.cpp |
Renamed a test identifier. |
library/tests/system/configure_tt_api_test.cpp |
Renamed two test identifiers. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tameware
added
the
Clean Copilot review
Co-authored-by: Cursor <cursoragent@cursor.com>
…ents. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honour→Honorandinitialise→initialize.ConfigureTtApiTestcitation inspecs/solver-context.md.AnalysePlay*, Pythonanalyse_*_pbn) are unchanged.Test plan
rg 'Honour|honour|Initialis|initialis'finds no remaining identifiersbazelisk test //library/tests/system:worker_count_test //library/tests/system:configure_tt_api_test //library/tests/trans_table:trans_tableMade with Cursor