Conversation
Separates PBN/LIN/DLM/sol loading from UI and solver glue so the main page script stays focused (dds-bridge#382). Co-authored-by: Cursor <cursoragent@cursor.com>
Keeps file parsers, Card/holdings, WASM queue, and DOM wiring in separate classic scripts so each concern stays clear (dds-bridge#382). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactor and associated loading, deployment, test, and documentation updates have no unresolved blocking issues.
Pull request overview
Refactors DDS Web into separate import, core, solver, and UI scripts while updating loading, deployment, tests, and documentation.
Changes:
- Extracts parser, deal-model, and solver logic.
- Updates classic-script loading and deployment assets.
- Extends tests and documents the new architecture.
File summaries
| File | Summary |
|---|---|
web/tests/web_site.py |
Test-site asset list |
web/tests/test_web_html.py |
Script-order checks |
web/tests/test_stage_github_pages.py |
Deployment checks |
web/tests/test_dds_web_js.py |
Node test paths |
web/tests/dds_web_test.mjs |
Layer-loading and behavior tests |
web/stage_github_pages.py |
GitHub Pages assets |
web/dds_web.js |
UI logic |
web/dds_web.html |
Classic-script load order |
web/dds_web_solve.js |
Solver and WASM logic |
web/dds_web_deal_import.js |
Deal parsers |
web/dds_web_core.js |
Deal model and helpers |
web/BUILD.bazel |
Build and test data |
specs/web.md |
Architecture documentation |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tameware
added
the
Clean Copilot review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per a suggestion from @tzimnoch
Summary
dds_web_deal_import.js(Refactor dds_web.js #382)dds_web_core.js(deal model),dds_web_solve.js(WASM queue / DD table / leads), anddds_web.js(DOM UI)Test plan
bazelisk test //web:dds_web_js_test //web:dds_web_html_test //web:stage_github_pages_testnode --test web/tests/dds_web_test.mjswith the four JS env paths setMade with Cursor