Simplify scheduleDealSolve control flow - #381
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…ance. Gate release and trailing restart already live in finally; single-threaded JS cannot interleave a schedule between the sync epoch check and clear. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Simplifies deal-solve scheduling and DLM payload parsing while preserving behavior.
Changes:
- Removes redundant queue-gate TOCTOU logic.
- Unrolls the two-card owner loop.
File summaries
| File | Summary |
|---|---|
web/dds_web.js |
Simplifies solve scheduling and DLM payload parsing. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
5 tasks
tameware
added
the
Clean Copilot review
tzimnoch
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dealSolveQueuedTOCTOU dance inscheduleDealSolve; gate release and trailing restart already live infinally.parseDlmBoardPayload.Test plan
node --test --test-name-pattern='rapid scheduleDealSolve|invalidateActiveDdTableRequest clears dealSolvePending|failed file import stops an in-flight solve' web/tests/dds_web_test.mjsMade with Cursor